Fix visualization by inverting open/closed state of patio awnings #128079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until the referenced architectural discussion is solved and support for new types of covers has been implemented natively, invert the reported state of patio awnings to match the expections of the UI visualizations based on the cover platform and solve representation of virtical awnings until those can be handled more differentiated. Ref: home-assistant/architecture#979
home-assistant
bot
added
breaking-change
bugfix
cla-signed
Hacktoberfest
has-tests
integration: wmspro
small-pr
mback2k
commented
Oct 10, 2024
|
|
||
| async def async_set_cover_position(self, **kwargs: Any) -> None: | ||
| """Move the cover to a specific position.""" | ||
| action = self._dest.action(WMS_WebControl_pro_API_actionDescription.AwningDrive) | ||
| await action(percentage=kwargs[ATTR_POSITION]) | ||
| await action(percentage=100 - kwargs[ATTR_POSITION]) | ||
|
|
||
| @property | ||
| def is_closed(self) -> bool | None: |
There was a problem hiding this comment.
As a middle-ground-solution, we could make this property function is_closed return the awning is closed (now meaning expanded) as soon as the current position in HA methodology is less than 100% (now meaning fully retracted) and therefore the awning being expanded even only a little bit. So, open would just mean fully retracted then to check it is really fully protected during storm/rain.
Any opinions about this?
mback2k
force-pushed
the
wmspro-fix-cover-state
branch
from
b1e6532 to
94d6d8d
Compare
joostlek
approved these changes
Oct 29, 2024
|
Thanks @joostlek 🙏🏻 |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The open/closed state of awnings will be inverted, so that the UI visualization and positioning matches reality. This means open (100%) now refers to the awning being completely retracted and closed (0%) now means the awning is fully expanded. This is not in line with industry terminology, but HA does not yet natively support awnings of type patio.
Proposed change
Until the referenced architectural discussion is solved and support for new types of covers has been implemented natively, invert the reported state of patio awnings to match the expections of the UI visualizations based on the cover platform and solve representation of virtical awnings until those can be handled more differentiated.
Details including screenshots without this change: home-assistant/architecture#979 (reply in thread)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: