Incorporate review feedback from joostlek

Author: mback2k

tests/components/wmspro/test_cover.py

@@ -2,24 +2,27 @@
 
 from unittest.mock import AsyncMock, patch
 
+from freezegun.api import FrozenDateTimeFactory
 from syrupy import SnapshotAssertion
 
 from homeassistant.components.wmspro.const import DOMAIN
+from homeassistant.components.wmspro.cover import SCAN_INTERVAL
 from homeassistant.const import (
     ATTR_ENTITY_ID,
     SERVICE_CLOSE_COVER,
     SERVICE_OPEN_COVER,
     SERVICE_SET_COVER_POSITION,
     SERVICE_STOP_COVER,
+    STATE_CLOSED,
+    STATE_OPEN,
     Platform,
 )
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers import device_registry as dr
-from homeassistant.setup import async_setup_component
 
 from . import setup_config_entry
 
-from tests.common import MockConfigEntry
+from tests.common import MockConfigEntry, async_fire_time_changed
 
 
 async def test_cover_device(
@@ -48,6 +51,7 @@ async def test_cover_update(
     mock_hub_ping: AsyncMock,
     mock_hub_configuration_prod: AsyncMock,
     mock_hub_status_prod_awning: AsyncMock,
+    freezer: FrozenDateTimeFactory,
     snapshot: SnapshotAssertion,
 ) -> None:
     """Test that a cover entity is created and updated correctly."""
@@ -60,15 +64,12 @@ async def test_cover_update(
     assert entity is not None
     assert entity == snapshot
 
-    await async_setup_component(hass, "homeassistant", {})
-    await hass.services.async_call(
-        "homeassistant",
-        "update_entity",
-        {ATTR_ENTITY_ID: entity.entity_id},
-        blocking=True,
-    )
+    # Move time to next update
+    freezer.tick(SCAN_INTERVAL)
+    async_fire_time_changed(hass)
+    await hass.async_block_till_done(wait_background_tasks=True)
 
-    assert len(mock_hub_status_prod_awning.mock_calls) == 3
+    assert len(mock_hub_status_prod_awning.mock_calls) >= 3
 
 
 async def test_cover_open_and_close(
@@ -87,7 +88,7 @@ async def test_cover_open_and_close(
 
     entity = hass.states.get("cover.markise")
     assert entity is not None
-    assert entity.state == "closed"
+    assert entity.state == STATE_CLOSED
     assert entity.attributes["current_position"] == 0
 
     with patch(
@@ -105,7 +106,7 @@ async def test_cover_open_and_close(
 
         entity = hass.states.get("cover.markise")
         assert entity is not None
-        assert entity.state == "open"
+        assert entity.state == STATE_OPEN
         assert entity.attributes["current_position"] == 100
         assert len(mock_hub_status_prod_awning.mock_calls) == before
 
@@ -124,7 +125,7 @@ async def test_cover_open_and_close(
 
         entity = hass.states.get("cover.markise")
         assert entity is not None
-        assert entity.state == "closed"
+        assert entity.state == STATE_CLOSED
         assert entity.attributes["current_position"] == 0
         assert len(mock_hub_status_prod_awning.mock_calls) == before
 
@@ -145,7 +146,7 @@ async def test_cover_open_to_pos(
 
     entity = hass.states.get("cover.markise")
     assert entity is not None
-    assert entity.state == "closed"
+    assert entity.state == STATE_CLOSED
     assert entity.attributes["current_position"] == 0
 
     with patch(
@@ -163,7 +164,7 @@ async def test_cover_open_to_pos(
 
         entity = hass.states.get("cover.markise")
         assert entity is not None
-        assert entity.state == "open"
+        assert entity.state == STATE_OPEN
         assert entity.attributes["current_position"] == 50
         assert len(mock_hub_status_prod_awning.mock_calls) == before
 
@@ -184,7 +185,7 @@ async def test_cover_open_and_stop(
 
     entity = hass.states.get("cover.markise")
     assert entity is not None
-    assert entity.state == "closed"
+    assert entity.state == STATE_CLOSED
     assert entity.attributes["current_position"] == 0
 
     with patch(
@@ -202,7 +203,7 @@ async def test_cover_open_and_stop(
 
         entity = hass.states.get("cover.markise")
         assert entity is not None
-        assert entity.state == "open"
+        assert entity.state == STATE_OPEN
         assert entity.attributes["current_position"] == 80
         assert len(mock_hub_status_prod_awning.mock_calls) == before
 
@@ -221,6 +222,6 @@ async def test_cover_open_and_stop(
 
         entity = hass.states.get("cover.markise")
         assert entity is not None
-        assert entity.state == "open"
+        assert entity.state == STATE_OPEN
         assert entity.attributes["current_position"] == 80
         assert len(mock_hub_status_prod_awning.mock_calls) == before