-
Notifications
You must be signed in to change notification settings - Fork 127
Merge duplicated error log entries into one #11434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
web3/src/main/java/org/hiero/mirror/web3/config/LoggingFilter.java
Outdated
Show resolved
Hide resolved
web3/src/main/java/org/hiero/mirror/web3/controller/GenericControllerAdvice.java
Outdated
Show resolved
Hide resolved
web3/src/main/java/org/hiero/mirror/web3/controller/GenericControllerAdvice.java
Outdated
Show resolved
Hide resolved
web3/src/main/java/org/hiero/mirror/web3/controller/GenericControllerAdvice.java
Outdated
Show resolved
Hide resolved
666192e
to
7267cec
Compare
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
web3/src/main/java/org/hiero/mirror/web3/exception/MirrorEvmTransactionException.java
Show resolved
Hide resolved
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
…e log size Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
Signed-off-by: Bilyana Gospodinova <[email protected]>
418b7bd
to
cdfd7b5
Compare
Description:
When a
MirrorEvmTransactionException
is thrown, currently there are 2 log entries for 1 transaction and this makes the investigation harder as you need to find both entries and match them. The first entry contained the request body input and the second entry contained the resulting error output.With this PR both log entries are now merged into one. If the length of the log gets bigger than the
maxPayloadLogSize
property, it gets encoded as it did before for the input data. Also, the empty components in the error message are now removed and added to the log only if they are not empty.Fixes #11054
Notes for reviewer:
Before:
After:
Checklist