Add tests that cover full exception message cases

Signed-off-by: Bilyana Gospodinova <[email protected]>

Author: bilyana-gospodinova

web3/src/main/java/org/hiero/mirror/web3/exception/MirrorEvmTransactionException.java

@@ -84,7 +84,7 @@ public String getFullMessage() {
         if (!StringUtils.isBlank(getDetail())) {
             exceptionMessageBuilder.append(", detail: ").append(getDetail());
         }
-        if (!getChildTransactionErrors().isEmpty()) {
+        if (getChildTransactionErrors() != null && !getChildTransactionErrors().isEmpty()) {
             exceptionMessageBuilder.append(", childTransactionErrors: ").append(getChildTransactionErrors());
         }
         exceptionMessageBuilder.append(", data: ").append(getData());

web3/src/test/java/org/hiero/mirror/web3/config/LoggingFilterTest.java

@@ -5,15 +5,22 @@
 import static com.google.common.net.HttpHeaders.X_FORWARDED_FOR;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.hiero.mirror.web3.utils.Constants.MODULARIZED_HEADER;
+import static org.springframework.web.util.WebUtils.ERROR_EXCEPTION_ATTRIBUTE;
 
+import com.hederahashgraph.api.proto.java.ResponseCodeEnum;
 import java.nio.charset.StandardCharsets;
+import java.util.LinkedList;
+import java.util.List;
 import lombok.SneakyThrows;
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.RandomStringUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.hiero.mirror.web3.Web3Properties;
+import org.hiero.mirror.web3.exception.MirrorEvmTransactionException;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.NullAndEmptySource;
 import org.springframework.boot.test.system.CapturedOutput;
 import org.springframework.boot.test.system.OutputCaptureExtension;
 import org.springframework.http.HttpStatus;
@@ -154,6 +161,110 @@ void postLargeUncompressibleContent(CapturedOutput output) {
         assertThat(output.getOut()).contains(content.substring(0, maxSize)).doesNotContain(content);
     }
 
+    @Test
+    @SneakyThrows
+    void getFullExceptionMessage(CapturedOutput output) {
+        int maxSize = web3Properties.getMaxPayloadLogSize();
+        var content = "abcdef0123456789";
+        var request = new MockHttpServletRequest("POST", "/");
+        request.setContent(content.getBytes(StandardCharsets.UTF_8));
+        request.setAttribute(
+                ERROR_EXCEPTION_ATTRIBUTE,
+                new MirrorEvmTransactionException(
+                        ResponseCodeEnum.CONTRACT_REVERT_EXECUTED.name(),
+                        "detail",
+                        "0123456",
+                        null,
+                        true,
+                        List.of("childMessage")));
+        response.setStatus(HttpStatus.OK.value());
+
+        loggingFilter.doFilter(request, response, (req, res) -> IOUtils.toString(req.getReader()));
+
+        assertThat(output.getOut())
+                .contains(
+                        "Mirror EVM transaction error: CONTRACT_REVERT_EXECUTED, detail: detail, childTransactionErrors: [childMessage], data: 0123456 - abcdef0123456789");
+    }
+
+    @ParameterizedTest
+    @NullAndEmptySource
+    @SneakyThrows
+    void getFullExceptionMessageDetailEmpty(final String detail, CapturedOutput output) {
+        int maxSize = web3Properties.getMaxPayloadLogSize();
+        var content = "abcdef0123456789";
+        var request = new MockHttpServletRequest("POST", "/");
+        request.setContent(content.getBytes(StandardCharsets.UTF_8));
+        request.setAttribute(
+                ERROR_EXCEPTION_ATTRIBUTE,
+                new MirrorEvmTransactionException(
+                        ResponseCodeEnum.CONTRACT_REVERT_EXECUTED.name(),
+                        detail,
+                        "0123456",
+                        null,
+                        true,
+                        List.of("childMessage")));
+        response.setStatus(HttpStatus.OK.value());
+
+        loggingFilter.doFilter(request, response, (req, res) -> IOUtils.toString(req.getReader()));
+
+        assertThat(output.getOut())
+                .contains(
+                        "Mirror EVM transaction error: CONTRACT_REVERT_EXECUTED, childTransactionErrors: [childMessage], data: 0123456 - abcdef0123456789");
+    }
+
+    @ParameterizedTest
+    @NullAndEmptySource
+    @SneakyThrows
+    void getFullExceptionMessageChildErrorsEmpty(final LinkedList<String> childErrors, CapturedOutput output) {
+        int maxSize = web3Properties.getMaxPayloadLogSize();
+        var content = "abcdef0123456789";
+        var request = new MockHttpServletRequest("POST", "/");
+        request.setContent(content.getBytes(StandardCharsets.UTF_8));
+        request.setAttribute(
+                ERROR_EXCEPTION_ATTRIBUTE,
+                new MirrorEvmTransactionException(
+                        ResponseCodeEnum.CONTRACT_REVERT_EXECUTED.name(),
+                        "detail",
+                        "0123456",
+                        null,
+                        true,
+                        childErrors));
+        response.setStatus(HttpStatus.OK.value());
+
+        loggingFilter.doFilter(request, response, (req, res) -> IOUtils.toString(req.getReader()));
+
+        assertThat(output.getOut())
+                .contains(
+                        "Mirror EVM transaction error: CONTRACT_REVERT_EXECUTED, detail: detail, data: 0123456 - abcdef0123456789");
+    }
+
+    @Test
+    @SneakyThrows
+    void getFullExceptionMessageWithCompressedContent(CapturedOutput output) {
+        int maxSize = web3Properties.getMaxPayloadLogSize();
+        var content = StringUtils.repeat("abcdefghij", maxSize / 10 + 1);
+        var request = new MockHttpServletRequest("POST", "/");
+        request.setContent(content.getBytes(StandardCharsets.UTF_8));
+        request.setAttribute(
+                ERROR_EXCEPTION_ATTRIBUTE,
+                new MirrorEvmTransactionException(
+                        ResponseCodeEnum.CONTRACT_REVERT_EXECUTED.name(),
+                        "detail",
+                        "0123456",
+                        null,
+                        true,
+                        List.of("childMessage")));
+        response.setStatus(HttpStatus.OK.value());
+
+        loggingFilter.doFilter(request, response, (req, res) -> IOUtils.toString(req.getReader()));
+
+        var compressed = "H4sIAAAAAAAA/0tMSk5JTUvPyMxKHGURzQIAy81t7zYBAAA=";
+        assertThat(output.getOut())
+                .contains(
+                        "Mirror EVM transaction error: CONTRACT_REVERT_EXECUTED, detail: detail, childTransactionErrors: [childMessage], data: 0123456 - "
+                                + compressed);
+    }
+
     private void assertLog(CapturedOutput logOutput, String level, String pattern) {
         assertThat(logOutput).asString().hasLineCount(1).contains(level).containsPattern(pattern);
     }