Skip to content

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 8, 2020

#227

Other PRs only change package-lock which is not published.

@curbengh curbengh requested a review from a team August 8, 2020 06:42
@coveralls
Copy link

coveralls commented Aug 8, 2020

Coverage Status

Coverage remained the same at 82.609% when pulling dc9ab3c on curbengh:v4.2.0 into 7322538 on hexojs:master.

@SukkaW
Copy link
Member

SukkaW commented Aug 8, 2020

Since there will be a newer version, I will merge those PRs that updates package-lock.json (With package-lock.json user will not be able to install the latest version of packages).

@curbengh
Copy link
Contributor Author

curbengh commented Aug 8, 2020

With package-lock.json user will not be able to install the latest version of packages

Only applies to devs/contributors who clone this repo. anyhow, I will rebase this PR.

@SukkaW
Copy link
Member

SukkaW commented Aug 8, 2020

@curbengh It is ok to merge & release a newer version now.

@curbengh curbengh merged commit 1989771 into hexojs:master Aug 8, 2020
@curbengh curbengh deleted the v4.2.0 branch August 8, 2020 12:03
@curbengh
Copy link
Contributor Author

curbengh commented Aug 8, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants