Skip to content

feat(init): support pnpm and drop yarn 2 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2020
Merged

feat(init): support pnpm and drop yarn 2 #227

merged 1 commit into from
Aug 8, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Jul 29, 2020

yarn 2 is not supported due to hexo's reliance on node_modules.

Package manager priority:

  1. yarn
  2. pnpm
  3. npm

@coveralls
Copy link

coveralls commented Jul 29, 2020

Coverage Status

Coverage decreased (-2.5%) to 82.609% when pulling 784def0 on curbengh:yarn-pnpm into 51a7766 on hexojs:master.

@curbengh
Copy link
Contributor Author

https://repl.it/repls/BlissfulPinkNetframework#index.js seems working, but it defaults to yarn though.

@curbengh curbengh marked this pull request as ready for review August 7, 2020 01:31
@curbengh
Copy link
Contributor Author

curbengh commented Aug 7, 2020

Tested in vanilla (non-WSL) windows 10.

Cases tested:

  1. npm
  2. yarn 1
  3. yarn 2
  4. pnpm

@curbengh curbengh requested a review from SukkaW August 7, 2020 01:32
@curbengh curbengh merged commit 2c171ff into hexojs:master Aug 8, 2020
@curbengh curbengh deleted the yarn-pnpm branch August 8, 2020 06:37
This was referenced Aug 8, 2020
@curbengh
Copy link
Contributor Author

curbengh commented Aug 8, 2020

hexojs/site#1370

@stevenjoezhang
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants