Skip to content

Skip ShouldDownloadAndExtractFirefoxLinuxBinary on Windows #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Skip ShouldDownloadAndExtractFirefoxLinuxBinary on Windows #2232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/PuppeteerSharp.Tests/Attributes/SkipWindowsFact.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
using System.Runtime.InteropServices;
using Xunit;

namespace PuppeteerSharp.Tests.Attributes
{
internal class SkipWindowsFact : FactAttribute
{
public SkipWindowsFact()
{
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
return;
}

Skip = "Test will not run on windows.";
}
}
}
2 changes: 1 addition & 1 deletion lib/PuppeteerSharp.Tests/LauncherTests/BrowserFetcherTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public async Task ShouldDownloadAndExtractLinuxBinary()
}

[PuppeteerTest("launcher.spec.ts", "BrowserFetcher", "should download and extract firefox linux binary")]
[PuppeteerFact]
[SkipWindowsFact]
public async Task ShouldDownloadAndExtractFirefoxLinuxBinary()
{
using var browserFetcher = Puppeteer.CreateBrowserFetcher(new BrowserFetcherOptions
Expand Down