Skip ShouldDownloadAndExtractFirefoxLinuxBinary on Windows
#2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The built-in Windows command 'tar' delegates handling of .tar.bzip2 archives to another command 'bzip2'. Windows 10 does not come with 'bzip2' pre-installed.
kblok
approved these changes
Jun 12, 2023
|
It's a shame that it does work on AppVeyor (Windows), but not on your local. But I get the point. It's more important to run this on Linux. |
leonardo-fernandes
pushed a commit
to leonardo-fernandes/puppeteer-sharp
that referenced
this pull request
Jun 13, 2023
…#2232) The built-in Windows command 'tar' delegates handling of .tar.bzip2 archives to another command 'bzip2'. Windows 10 does not come with 'bzip2' pre-installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in Windows command
tardelegates handling of .tar.bzip2 archives to another commandbzip2.Windows 10 does not come with
bzip2pre-installed.Tests can only be decorated with a single attribute deriving from
FactAttribute, that's the reason I replacedPuppeteerFact.Fixes #2130