-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
fix: the rawType of Content was not updated when switching editors #3516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@intoyang 需要签署一下 CLA |
这里也需要修改一下: halo/console/src/modules/contents/pages/SinglePageEditor.vue Lines 45 to 51 in f43888b
|
Codecov Report
@@ Coverage Diff @@
## main #3516 +/- ##
=========================================
Coverage 61.60% 61.60%
Complexity 2509 2509
=========================================
Files 398 398
Lines 12695 12695
Branches 1019 1019
=========================================
Hits 7821 7821
Misses 4388 4388
Partials 486 486 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) > **Warning** > > 此 PR 的改动来自:<halo-dev/halo#3516> > 因为目前 Console 仓库已经合并到 Halo 主仓库,但主仓库的 release-2.3 分支不包含 Console,所以如果需要发布 2.3.x 的 patch 版本,依旧需要在此仓库修改。 #### What type of PR is this? /kind bug /milestone 2.3.2 #### What this PR does / why we need it: 修复在新建文章时,首次切换编辑器后没有设置内容 rawType 资源为对应编辑器类型的问题。 #### Which issue(s) this PR fixes: Fixes #3512 #### Special notes for your reviewer: 测试方式: 1. 安装任意一个编辑器插件,比如:https://github.com/halo-sigs/plugin-stackedit 1. 新建文章,选择安装的编辑器。 1. 发布文章。 1. 卸载或者停止编辑器。 1. 重新编辑刚刚创建的文章,如果提示 `未找到符合 markdown 格式的编辑器,请检查是否已安装编辑器插件` 则代表正常。 #### Does this PR introduce a user-facing change? ```release-note 修复在新建文章时,首次切换编辑器后没有设置内容 rawType 资源为对应编辑器类型的问题。 ```
cherry pick release-2.3? |
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
修复在新建文章时,首次切换编辑器后没有设置内容 rawType 资源为对应编辑器类型的问题。
Which issue(s) this PR fixes:
Fixes #3512
Special notes for your reviewer:
测试方式:
未找到符合 markdown 格式的编辑器,请检查是否已安装编辑器插件
则代表正常。Does this PR introduce a user-facing change?