Skip to content
This repository was archived by the owner on Jan 21, 2024. It is now read-only.

fix: the rawType of Content was not updated when switching editors #904

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 15, 2023

Warning

此 PR 的改动来自:halo-dev/halo#3516
因为目前 Console 仓库已经合并到 Halo 主仓库,但主仓库的 release-2.3 分支不包含 Console,所以如果需要发布 2.3.x 的 patch 版本,依旧需要在此仓库修改。

What type of PR is this?

/kind bug
/milestone 2.3.2

What this PR does / why we need it:

修复在新建文章时,首次切换编辑器后没有设置内容 rawType 资源为对应编辑器类型的问题。

Which issue(s) this PR fixes:

Fixes #3512

Special notes for your reviewer:

测试方式:

  1. 安装任意一个编辑器插件,比如:https://github.com/halo-sigs/plugin-stackedit
  2. 新建文章,选择安装的编辑器。
  3. 发布文章。
  4. 卸载或者停止编辑器。
  5. 重新编辑刚刚创建的文章,如果提示 未找到符合 markdown 格式的编辑器,请检查是否已安装编辑器插件 则代表正常。

Does this PR introduce a user-facing change?

修复在新建文章时,首次切换编辑器后没有设置内容 rawType 资源为对应编辑器类型的问题。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 15, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.2 milestone Mar 15, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG March 15, 2023 03:35
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 15, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from QuentinHsu March 15, 2023 03:35
@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 3:36AM (UTC)

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@JohnNiang
Copy link
Member

/cherrypick release-2.3

@halo-dev-bot
Copy link

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang
Copy link
Member

/cherrypick release-2.2

@halo-dev-bot
Copy link

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang
Copy link
Member

/cherrypick release-2.1

@halo-dev-bot
Copy link

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot
Copy link

@JohnNiang: new pull request created: #909

In response to this:

/cherrypick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot
Copy link

@JohnNiang: new pull request created: #910

In response to this:

/cherrypick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot
Copy link

@JohnNiang: new pull request created: #911

In response to this:

/cherrypick release-2.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Mar 15, 2023
…ing editors (#910)

This is an automated cherry-pick of #904

/assign JohnNiang

```release-note
修复在新建文章时,首次切换编辑器后没有设置内容 rawType 资源为对应编辑器类型的问题。
```
f2c-ci-robot bot pushed a commit that referenced this pull request Mar 15, 2023
…ing editors (#909)

This is an automated cherry-pick of #904

/assign JohnNiang

```release-note
修复在新建文章时,首次切换编辑器后没有设置内容 rawType 资源为对应编辑器类型的问题。
```
f2c-ci-robot bot pushed a commit that referenced this pull request Mar 15, 2023
…ing editors (#911)

This is an automated cherry-pick of #904

/assign JohnNiang

```release-note
修复在新建文章时,首次切换编辑器后没有设置内容 rawType 资源为对应编辑器类型的问题。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants