netty: Fix NPE in NettyClientTransport when keepalive is enabled #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Feb 15, 2017
| } | ||
|
|
||
| @Test | ||
| public void keepAliveEnabled() throws Exception { |
Member
There was a problem hiding this comment.
Could you do an RPC in each of these tests and just make sure you get OK? That will check many of the == null checks in the code.
Fixes NPE when keepalive is enabled. * Move creation of keepAliveManager to the bottom of start() * Enable keepAlive in NettyClientTransportTest * Add test cases checking if keepalive is enabled/disabled, specifically. Fixes grpc#2726
lukaszx0
force-pushed
the
fix-keepalive-npe
branch
from
019f8b7 to
24eae85
Compare
ejona86
approved these changes
Feb 16, 2017
Member
|
retest this please (comment to Jenkins) |
Member
|
Thanks @lukaszx0! |
ejona86
added
the
TODO:backport
|
Can't wait to see this fix released |
ejona86
removed
the
TODO:backport
|
Any plan to release this backport fix? |
Contributor
|
@bobwenx probably not, it will show up in 1.2 which will be released in about 2 weeks. |
|
@carl-mastrangelo 2 weeks past, is there any progress on the 1.2 released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keepAliveManagerto the bottom ofstart()NettyClientTransportTestFixes #2726
cc @ejona86 @bobwenx