KeepAliveManager is not apply to ConnectionHandler in netty transport

[bobwenx]

What version of gRPC are you using?

GRPC 1.2.0

What JVM are you using (java -version)?

1.8.0_112

What did you do?

I am try to make KeepAlive work with netty transport just now(grpc-java 1.2.0), and after some function test, i think the KeepAlive feature still not work functionally.

Debugging the code(io.grpc.netty.NettyClientTransport#start):

So, we known the KeepAliveManager only make effective in io.grpc.netty.NettyClientHandler instance. But the code showing the creation of io.grpc.netty.NettyClientHandler always receive a null keepAliveManager.

Probably because the keepAliveManager field is assigning in the end of io.grpc.netty.NettyClientTransport#start() call.

Associated commit: #2729: the commit resolve the problem of NPE(#2726)

cc @lukaszx0 @ejona86

[dapengzhang0]

thanks for the notice.
Seems happened after #2729, will fix it.

[bobwenx]

Hi there! Any plan to release 1.3.x? KeepAlive support is a important feature for us :)

[ejona86]

@bobwenx, 1.3.0 is now available. It's not yet showing up on search.maven.org, but it is available for download. We've not yet made the release announcement, but it's in the works.

[bobwenx]

@ejona86 maybe a related issue: #2982