xds: avoid unnecessary dns lookup #11932
Merged
+82
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
reviewed
Mar 3, 2025
sergiitk
reviewed
Mar 4, 2025
| abstract int prefixLen(); | ||
|
|
||
| static CidrRange create(String addressPrefix, int prefixLen) throws UnknownHostException { | ||
| static CidrRange create(InetAddress addressPrefix, int prefixLen) { |
Member
There was a problem hiding this comment.
Why did you change the signature? String addressPrefix constructor seems pretty useful, given that we get a string in a proto.
ejona86
reviewed
Mar 4, 2025
ejona86
approved these changes
Mar 5, 2025
| @Test | ||
| public void sourcePrefixRange_2Matchers_expectException() | ||
| throws UnknownHostException { | ||
| public void sourcePrefixRange_2Matchers_expectException() throws IllegalArgumentException { |
Member
There was a problem hiding this comment.
throws IllegalArgumentException doesn't do anything because it is a RuntimeException.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11926