Skip to content

xds: xDS server - unnecessary dns lookup (blocking) when parsing FilterChainMatch address prefixes? #11926

@sergiitk

Description

@sergiitk

A bit strange that EnvoyServerProtoData.CidrRange.create uses InetAddress.getByName, which will perform a DNS lookup when a hostname provided in addressPrefix:

static CidrRange create(String addressPrefix, int prefixLen) throws UnknownHostException {
return new AutoValue_EnvoyServerProtoData_CidrRange(
InetAddress.getByName(addressPrefix), prefixLen);
}
}

Should we be using Guava's InetAddresses#forString which is "deliberately avoids all nameservice lookups"?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions