-
-
Notifications
You must be signed in to change notification settings - Fork 599
Make the tests faster #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1eb26bb
run all of the integration tests in parallel
calebmer c40ea1d
move test utilities
calebmer e5c6ec0
only introspect catalog once
calebmer d74c661
speed up some tests
calebmer 2751fb2
set a max workers count
calebmer 0c229c9
add a thing
calebmer 6670619
remove a thing to trigger build
calebmer ca7b3ba
fix lint errors
calebmer 48741f1
fix integration queries with different configurations
calebmer d1bc9ab
only test Koa in versions of Node.js greater than 4
calebmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ | |
|
||
npm_bin=$(npm bin) | ||
|
||
$npm_bin/jest $@ | ||
$npm_bin/jest --maxWorkers 3 $@ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
* Runs all of the tests declared with this funcion in a file in parallel. This | ||
* breaks any `beforeEach` and `afterEach` functions, but any `beforeAll` and | ||
* `afterAll` functions should work. | ||
* | ||
* This function will break the timing numbers in the Jest console. | ||
*/ | ||
export default function createTestInParallel(): (name: string, fn: () => void | Promise<void>) => void { | ||
// All of the test functions. We collect them in a single array so that we can | ||
// call them all at once. | ||
const testFns: Array<() => void | Promise<void>> = [] | ||
|
||
// The promised results of calling all of our test functions. The single serial | ||
// tests will await these values. | ||
let testResults: Array<Promise<void>> | undefined | ||
|
||
return (name: string, fn: () => void | Promise<void>): void => { | ||
// Add the test function and record its position. | ||
const index = testFns.length | ||
testFns.push(fn) | ||
|
||
test(name, async () => { | ||
// If the tests have not yet been run then run all of our tests. | ||
if (!testResults) { | ||
testResults = testFns.map(testFn => Promise.resolve(testFn())) | ||
} | ||
// Await the result. | ||
await testResults[index] | ||
}) | ||
} | ||
} |
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.