Make the tests faster #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like tests on CI went from 30s to 10s. |
|
Nice. Looks like we can't use snapshot tests when we're expecting errors though: |
benjie
reviewed
Mar 25, 2017
| } | ||
| // Await the result. | ||
| await testResults[index] | ||
| }) |
|
Snapshot tests are still fine. That one snapshot test failed because it looks like the error message is different in Node.js 4 then in Node.js 6, however seeing that helped me catch a bug I forgot to fix 😊 The second error causing the tests to crash is because Koa ships some ES2015 syntax in its source code that Node.js 4 doesn’t like. So the fix was to not test Koa if the Node.js major version is less than or equal to 4. |
Belline
pushed a commit
to Belline/postgraphql
that referenced
this pull request
Dec 18, 2017
* run all of the integration tests in parallel * move test utilities * only introspect catalog once * speed up some tests * set a max workers count * add a thing * remove a thing to trigger build * fix lint errors * fix integration queries with different configurations * only test Koa in versions of Node.js greater than 4
benjie
added a commit
that referenced
this pull request
Jan 27, 2020
benjie
added a commit
that referenced
this pull request
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the test suites are pretty slow, so this PR aims to speed up our tests. With this PR tests go from 42 seconds to 12 seconds on my machine 🎉
The secret to pretty much all of the perf wins is parallelization. Jest does not automatically parallelize tests which is fine when testing synchronous code, but is not ok for some of the heavy asynchronous tests we end up running.
We were also repeating a lot of introspection work so I tried to get clients and introspections to be shared as much as possible.