Disambiguate name in glade strings #2097
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR appears to contain more commits than intended. |
|
The target branch was master - which was not intended. Switched target branch. |
Nick-Hall
changed the title
Nick-Hall
force-pushed
the
disambiguate-name-in-glade-strings
branch
from
7502999 to
7b5599c
Compare
Nick-Hall
merged commit 7b5599c
into
gramps-project:maintenance/gramps60
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds context to the 'Name' strings in .glade files to enable disambiguation and using different translations depending on the context. The problem is described in bug 12527.
Here is problem example.
Currently there is context missing and in .po file there is e.g. for Polish localization:
#: ../gramps/gen/filters/rules/person/_hassoundexname.py:57
#: ../gramps/gui/glade/editfamily.glade:116
#: ../gramps/gui/glade/editfamily.glade:379
#: ../gramps/gui/glade/editplaceformat.glade:201
#: ../gramps/gui/glade/editplacename.glade:184
#: ../gramps/gui/glade/editplaceref.glade:234
#: ../gramps/gui/glade/mergeperson.glade:218
#: ../gramps/gui/glade/mergeperson.glade:233
#: ../gramps/gui/glade/mergeplace.glade:426
#: ../gramps/gui/glade/mergeplace.glade:443
#: ../gramps/plugins/gramplet/soundgen.py:68
msgid "Name:"
msgstr "Imię i nazwisko:"
The msgstr is correct in
personcontext but is totally wrong inplacecontext and they can't be translated separately dur to context missing.This PR enables this distinction.