Skip to content

Improve OS X current-wifi determination #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve OS X current-wifi determination #819

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
469a97d
Improve OS X current-wifi determination
autopulated Aug 12, 2025
f880eb4
lint
autopulated Aug 12, 2025
8b9facc
add missing raises: spec to docstring
autopulated Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions demos/python/sdk_wireless_camera_control/open_gopro/network/wifi/adapters/wireless.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,9 @@ async def disconnect(self) -> bool:
def current(self) -> tuple[str | None, SsidState]:
"""Get the currently connected SSID if there is one.

Raises:
RuntimeError: the current Wi-Fi network is redacted

Returns:
tuple[str | None, SsidState]: (SSID or None if not connected, SSID state)
"""
Expand All @@ -794,9 +797,12 @@ def current(self) -> tuple[str | None, SsidState]:
ssid = output.replace("Current Wi-Fi Network: ", "").strip()
except Exception as e:
pass
# For current MacOs versions or if above failed
if match := re.search(r"\n\s+SSID : ([\x20-\x7E]{1,32})", cmd(f"ipconfig getsummary {self.interface}")):
ssid = match.group(1)
if ssid is None:
# For current MacOs versions or if above failed
if match := re.search(r"\n\s+SSID : ([\x20-\x7E]{1,32})", cmd(f"ipconfig getsummary {self.interface}")):
ssid = match.group(1)
if ssid == "<redacted>":
raise RuntimeError("current Wi-Fi network is redacted")

return (ssid, SsidState.CONNECTED) if ssid else (None, SsidState.DISCONNECTED)

Expand Down
Loading