Improve OS X current-wifi determination #819
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not call ipconfig getsummary unnecessarily if networksetup succeeded: In some cases networksetup has returned the correct SSID, but ipconfig will return a <redacted> value. If the ssid value is still redacted, then throwing an error prevents mysterious timeout failures, and exposes the real cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OS X 14.7, I experienced an issue where attempting to connect would timeout. This turned out to be because
NetworksetupWireless.current()was callingipconfigto get the current SSID, even after a successful call tonetworksetup.ipconfigwas returning<redacted>, overwriting the correct result fromnetworksetup.Happily, my problem was fixed by just skipping the
ipconfigcall (which seems like the original intention of this code, and a straightforward bug), but I've also added an explicit exception if a<redacted>value is returned, which will make the cause easier to diagnose if this happens for anyone else.I'm not sure under which circumstances exactly these commands can return
<redacted>values, but it seems like it's a privacy protection measure in recent OS X, which can be resolved by explicitly asking for location services permission.