Skip to content

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented May 2, 2025

This is generic library-wide replacement of the following:

Topic -> Publisher
Subscription -> Subscriber

This includes both docs, the API surface (via exposed Errors) and helper methods/library internals.

This is part of #11368

@hongalex hongalex requested review from shollyman and a team as code owners May 2, 2025 21:51
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label May 2, 2025
@hongalex hongalex requested review from a team as code owners May 2, 2025 21:57
Copy link

snippet-bot bot commented May 2, 2025

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@hongalex hongalex removed request for a team May 2, 2025 21:58
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I contemplated whether aliasing the old error types would be useful, but the renames here are all consistent enough that migrating consumers should be able to work out the new exported names.

@hongalex hongalex merged commit a593036 into googleapis:pubsub-v2-trunk May 6, 2025
5 of 8 checks passed
@hongalex hongalex deleted the pubsub-v2-rename branch May 6, 2025 17:43
@hongalex hongalex mentioned this pull request May 6, 2025
22 tasks
hongalex added a commit that referenced this pull request Jul 14, 2025
* move existing files to v2

* add pstest and testdata directories

* chore(pubsub): rewrite v2 files with new package (#11292)

* chore(pubsub): remove handwritten layer from v2 (#11367)

* refactor imports to support v2

* remove handwritten schema client

* remove handwritten topic admin methods

* remove handwritten subscription admin methods

* remove admin operations only tests

* delete handwritten snapshot methods

* deprecate(pubsub/v2): remove and rename existing settings (#11375)

* deprecate(pubsub/v2): deprecate and rename user settings

* remove more code related to synchronous and byte limit

* refactor(pubsub/v2): make tests use new GAPIC library (#11429)

* refactor(pubsub/v2): make tests use new GAPIC library

* remove examples for list operations that are no longer part of this library

* feat(pubsub/v2): rename data plane clients (#11376)

* rename data plane clients

* add renamed data clients

* revert changes to filenames

* rename subscriber

* fix go docs referencing topic/subs

* fix remaining data client renames

* remove unused publisher method

* remove TopicInProject

remove TopicInProject

* feat(pubsub): rename lease settings, change byte limit default (#11963)

* chore(pubsub): restore updated v1 go files (#12011)

* chore(pubsub): revert v2 gapic to head (#12090)

* chore(pubsub): revert v2 gapic to HEAD

* revert info.go changes

* chore(pubsub): module and workspace updates (#12106)

* chore(pubsub): replace go.mod and go.work files in v1

* fix go.work formatting

* run go mod tidy

* chore(pubsub): rename data plane clients (#12108)

* chore(pubsub): rename data clients and update documentation

* more data plane renaming

* update repo-metadata and module files

* update copyright header for new files

* update go mod and work files

* add deprecation notice for pubsub v1

* fix exported comments

* feat(pubsub/v2): remove dependency on v2 fake (#12248)

* remove v2 fake

* remove lingering import of v2 pstest

* run go mod tidy

* bump google.golang.org/api version

* feat(pubsub/v2): add back fake and internal packages (#12292)

* feat(pubsub): add back v2 helper libraries

* fix copyright header year for new files

* update internal/testutil package version

* chore: alias v1 pubsub types

* chore(pubsub/v2): rename call options (#12519)

* chore(pubsub/v2): rename call options

* fix variable name

* chore(pubsub/v2): carve out v2 module (#12509)

* docs(pubsub): add migration guide to v2 (#12547)

* docs(pubsub): add migration guide to v2

* additional code formatting and edits to migration guide

* format code migration guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants