Skip to content

deprecate(pubsub/v2): remove and rename existing settings #11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Jan 6, 2025

Part of #11368

  • Settings refactoring (removal, renaming, default settings changes below)
    • Remove data plane logic for synchronous mode
    • BufferedByteLimit logic is now synonymous with MaxOutstandingBytes

Removal

  • PublishSettings.BufferedByteLimit
  • ReceiveSettings.Synchronous
  • ReceiveSettings.UseLegacyFlowControl

Rename

  • MaxExtensionPeriod -> MaxDurationPerLeaseExtension
  • MinExtensionPeriod -> MinDurationPerLeaseExtension

Default changes

  • NumGoroutines (aka num streams) = 10 -> 1

@hongalex hongalex requested review from shollyman and a team as code owners January 6, 2025 22:30
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jan 6, 2025
@hongalex hongalex changed the base branch from main to pubsub-v2-trunk January 6, 2025 22:30
@hongalex hongalex mentioned this pull request Jan 6, 2025
22 tasks
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hongalex hongalex merged commit 46f091f into googleapis:pubsub-v2-trunk Jan 7, 2025
152 of 173 checks passed
@hongalex hongalex deleted the pubsub-v2-settings-change branch January 7, 2025 19:30
hongalex added a commit that referenced this pull request Jul 14, 2025
* move existing files to v2

* add pstest and testdata directories

* chore(pubsub): rewrite v2 files with new package (#11292)

* chore(pubsub): remove handwritten layer from v2 (#11367)

* refactor imports to support v2

* remove handwritten schema client

* remove handwritten topic admin methods

* remove handwritten subscription admin methods

* remove admin operations only tests

* delete handwritten snapshot methods

* deprecate(pubsub/v2): remove and rename existing settings (#11375)

* deprecate(pubsub/v2): deprecate and rename user settings

* remove more code related to synchronous and byte limit

* refactor(pubsub/v2): make tests use new GAPIC library (#11429)

* refactor(pubsub/v2): make tests use new GAPIC library

* remove examples for list operations that are no longer part of this library

* feat(pubsub/v2): rename data plane clients (#11376)

* rename data plane clients

* add renamed data clients

* revert changes to filenames

* rename subscriber

* fix go docs referencing topic/subs

* fix remaining data client renames

* remove unused publisher method

* remove TopicInProject

remove TopicInProject

* feat(pubsub): rename lease settings, change byte limit default (#11963)

* chore(pubsub): restore updated v1 go files (#12011)

* chore(pubsub): revert v2 gapic to head (#12090)

* chore(pubsub): revert v2 gapic to HEAD

* revert info.go changes

* chore(pubsub): module and workspace updates (#12106)

* chore(pubsub): replace go.mod and go.work files in v1

* fix go.work formatting

* run go mod tidy

* chore(pubsub): rename data plane clients (#12108)

* chore(pubsub): rename data clients and update documentation

* more data plane renaming

* update repo-metadata and module files

* update copyright header for new files

* update go mod and work files

* add deprecation notice for pubsub v1

* fix exported comments

* feat(pubsub/v2): remove dependency on v2 fake (#12248)

* remove v2 fake

* remove lingering import of v2 pstest

* run go mod tidy

* bump google.golang.org/api version

* feat(pubsub/v2): add back fake and internal packages (#12292)

* feat(pubsub): add back v2 helper libraries

* fix copyright header year for new files

* update internal/testutil package version

* chore: alias v1 pubsub types

* chore(pubsub/v2): rename call options (#12519)

* chore(pubsub/v2): rename call options

* fix variable name

* chore(pubsub/v2): carve out v2 module (#12509)

* docs(pubsub): add migration guide to v2 (#12547)

* docs(pubsub): add migration guide to v2

* additional code formatting and edits to migration guide

* format code migration guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants