Skip to content

Fix incorrect leaf hash calculation for precertificates in upload command #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

Fix incorrect leaf hash calculation for precertificates in upload command #1710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
540fa11
Fix incorrect leaf hash calculation for precertificates in upload com…
Barre Jun 14, 2025
e881f60
Merge branch 'master' into fix-upload-precert-leaf-hash
phbnf Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion client/ctclient/cmd/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,15 @@ func runUpload(ctx context.Context) {
exitWithDetails(err)
}
// Calculate the leaf hash.
leafEntry := ct.CreateX509MerkleTreeLeaf(chain[0], sct.Timestamp)
var leafEntry *ct.MerkleTreeLeaf
if isPrecert {
leafEntry, err = ct.MerkleTreeLeafFromRawChain(chain, ct.PrecertLogEntryType, sct.Timestamp)
if err != nil {
klog.Exitf("Failed to build pre-certificate leaf entry: %v", err)
}
} else {
leafEntry = ct.CreateX509MerkleTreeLeaf(chain[0], sct.Timestamp)
}
leafEntry.TimestampedEntry.Extensions = sct.Extensions
leafHash, err := ct.LeafHashForLeaf(leafEntry)
if err != nil {
Expand Down
Loading