Fix incorrect leaf hash calculation for precertificates in upload command #1710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upload command was using
CreateX509MerkleTreeLeaf
for all certificates, including precertificates. This creates leaves withX509LogEntryType
, but precertificates must usePrecertLogEntryType
with aPreCert
structure containing the issuer key hash.This mismatch caused 'Leaf not found' errors when attempting to get inclusion proofs for re-uploaded precertificates (MMD 24h), as the calculated leaf hash didn't match the hash stored in the log.
The fix uses
MerkleTreeLeafFromRawChain
with the correct entry type, matching the approach used inget_inclusion_proof.go
.Before:
Now:
Checklist