Skip to content

Refactoring changes to create a test runner option from passed flags, correct indentation and add package level comment for test #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

Refactoring changes to create a test runner option from passed flags, correct indentation and add package level comment for test #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
684bc76
corrected indentation and added package comment for /test
aakash070 Apr 16, 2025
0820249
fix indentation for required_labels test file
aakash070 Apr 16, 2025
00c85a5
added test runner options from flags as a public method
aakash070 Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions policy/testdata/context_pb/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ description: "Protobuf input tests"
section:
- name: "valid"
tests:
- name: "good spec"
context_expr: "test.TestAllTypes{single_int32: 10}"
output:
expr: "optional.none()"
- name: "good spec"
context_expr: "test.TestAllTypes{single_int32: 10}"
output:
expr: "optional.none()"
- name: "invalid"
tests:
- name: "bad spec"
context_expr: "test.TestAllTypes{single_int32: 11}"
output:
value: "invalid spec, got single_int32=11, wanted <= 10"
- name: "bad spec"
context_expr: "test.TestAllTypes{single_int32: 11}"
output:
value: "invalid spec, got single_int32=11, wanted <= 10"
32 changes: 16 additions & 16 deletions policy/testdata/nested_rule7/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,27 @@ description: "Nested rule tests which explore optional vs non-optional returns"
section:
- name: "valid"
tests:
- name: "x=1"
input:
- name: "x=1"
input:
x:
value: 1
output:
expr: "optional.none()"
- name: "x=2"
input:
output:
expr: "optional.none()"
- name: "x=2"
input:
x:
value: 2
output:
value: false
- name: "x=3"
input:
output:
value: false
- name: "x=3"
input:
x:
value: 3
output:
value: true
- name: "x=4"
input:
output:
value: true
- name: "x=4"
input:
x:
value: 4
output:
value: true
output:
value: true
28 changes: 14 additions & 14 deletions policy/testdata/pb/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@ description: "Protobuf input tests"
section:
- name: "valid"
tests:
- name: "good spec"
input:
spec:
expr: >
test.TestAllTypes{single_int32: 10}
output:
expr: "optional.none()"
- name: "good spec"
input:
spec:
expr: >
test.TestAllTypes{single_int32: 10}
output:
expr: "optional.none()"
- name: "invalid"
tests:
- name: "bad spec"
input:
spec:
expr: >
test.TestAllTypes{single_int32: 11}
output:
value: "invalid spec, got single_int32=11, wanted <= 10"
- name: "bad spec"
input:
spec:
expr: >
test.TestAllTypes{single_int32: 11}
output:
value: "invalid spec, got single_int32=11, wanted <= 10"
116 changes: 58 additions & 58 deletions policy/testdata/required_labels/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,65 +16,65 @@ description: "Required labels conformance tests"
section:
- name: "valid"
tests:
- name: "matching"
input:
spec:
value:
labels:
env: prod
experiment: "group b"
resource:
value:
labels:
env: prod
experiment: "group b"
release: "v0.1.0"
output:
expr: "optional.none()"
- name: "matching"
input:
spec:
value:
labels:
env: prod
experiment: "group b"
resource:
value:
labels:
env: prod
experiment: "group b"
release: "v0.1.0"
output:
expr: "optional.none()"
- name: "missing"
tests:
- name: "env"
input:
spec:
value:
labels:
env: prod
experiment: "group b"
resource:
value:
labels:
experiment: "group b"
release: "v0.1.0"
output:
value: "missing one or more required labels: [\"env\"]"
- name: "experiment"
input:
spec:
value:
labels:
env: prod
experiment: "group b"
resource:
value:
labels:
env: staging
release: "v0.1.0"
output:
value: "missing one or more required labels: [\"experiment\"]"
- name: "env"
input:
spec:
value:
labels:
env: prod
experiment: "group b"
resource:
value:
labels:
experiment: "group b"
release: "v0.1.0"
output:
value: "missing one or more required labels: [\"env\"]"
- name: "experiment"
input:
spec:
value:
labels:
env: prod
experiment: "group b"
resource:
value:
labels:
env: staging
release: "v0.1.0"
output:
value: "missing one or more required labels: [\"experiment\"]"
- name: "invalid"
tests:
- name: "env"
input:
spec:
value:
labels:
env: prod
experiment: "group b"
resource:
value:
labels:
env: staging
experiment: "group b"
release: "v0.1.0"
output:
value: "invalid values provided on one or more labels: [\"env\"]"
- name: "env"
input:
spec:
value:
labels:
env: prod
experiment: "group b"
resource:
value:
labels:
env: staging
experiment: "group b"
release: "v0.1.0"
output:
value: "invalid values provided on one or more labels: [\"env\"]"
4 changes: 2 additions & 2 deletions policy/testdata/restricted_destinations/base_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ variables:
- name: "request"
type_name: "map"
params:
- type_name: "string"
- type_name: "dyn"
- type_name: "string"
- type_name: "dyn"
- name: "resource"
type_name: "map"
params:
Expand Down
Loading