Skip to content

Conversation

@stayallive
Copy link
Collaborator

Using this in my own apps for some time, seems like a sane approach to do the following when working queue jobs:

  • Send unsent errors as soon as a job is processed since another might take a while to come and the process may not end soon (so make sure all events are sent)
  • Clear the breadcrumbs as soon as a job is processed and events have been sent so there is a clean breadcrumbs record instead of piling on crumbs
  • Add an crumb to indicate which job started and add some metadata about the job

@Jean85 Does this seem like a good approach to take (conceptually)?

# Conflicts:
#	src/Sentry/SentryLaravel/SentryLaravelEventHandler.php
@stayallive stayallive merged commit a435753 into master Nov 1, 2018
@stayallive stayallive deleted the feat-listen-queue-events branch November 1, 2018 11:32
@stayallive stayallive mentioned this pull request Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants