Add tag with name of console command #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listen for the `CommandStarting` event and add a tag with the name of the console command. This makes it easy to know which console command has the error. Note: I did not typehint `ComandStarting` in `commandStartingHandler` because then I think it would only work on Laravel >=5.5 and based on the documentation this package supports Laravel 5.*. I'm surprised that the typehint of `MessageLogged` on `messageLoggedHandler` does not cause issues for people trying to use older versions of Laravel since `MessageLogged` was not added until Laravel 5.4.
Collaborator
|
Hey @ejunker, thanks for taking the time to make this PR. Because of autoloading you can Also I added the CommandFinished event to reset the command in case it was called from a web request, sounds good? (maybe you also want to take a look at #153 which adds event listeners for queue events) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen for the
CommandStartingevent and add a tag with the name of the console command. This makes it easy to know which console command has the error.Note: I did not typehint
ComandStartingincommandStartingHandlerbecause then I think it would only work on Laravel >=5.5 and based on the documentation this package supports Laravel 5.*. I'm surprised that the typehint ofMessageLoggedonmessageLoggedHandlerdoes not cause issues for people trying to use older versions of Laravel sinceMessageLoggedwas not added until Laravel 5.4.