-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Enable Ruff rule blind-except
#3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Ruff rule blind-except
#3493
Conversation
|
Hey Elliot. Thanks for working on this. Given that your aforementioned Ruff PR was merged, is this pull request still relevant? |
It oughtn't make any difference if we merge now. If we merge after the next Ruff release, then I expect we'll remove the two inline warning suppressions before merging. |
08e43a5 to
5d705df
Compare
Note that two inline suppressions are used. I expect, provided that my [PR](astral-sh/ruff#19520) is merged in, that these suppressions will become superfluous in a later version of Ruff.
5d705df to
10c0c29
Compare
|
I've removed the warning suppressions and bumped Ruff to |
|
Odd. Tests pass on my local workstation, both on |
|
@getpelican/reviewers: Could you possibly help diagnose why a bunch of tests are failing on |
|
I have nothing useful yet, but I can say
I'll get back to this later. |
|
@boxydog: Thank you for your investigative efforts. Much appreciated! You should be able to list the available Invoke tasks via: |
|
It looks like main doesn't pass either. I'm betting some dependency has changed. The dependencies in pyproject.toml allow a lot of different combinations. I'm experimenting with combinations of dependencies. |
|
Filed #3507, which says that docutils >= 0.22 fails. |
blind-except.blind-except
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks to @clockback for the enhancement and to @boxydog for tracking down the source of the test failures 👍
Note that two inline suppressions are used. I expect, provided that my PR is merged in, that these suppressions will become superfluous in a later version of Ruff.
Pull Request Checklist
Added tests for changed codeUpdated documentation for changed code