Skip to content

Conversation

@clockback
Copy link
Contributor

Note that two inline suppressions are used. I expect, provided that my PR is merged in, that these suppressions will become superfluous in a later version of Ruff.

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@justinmayer
Copy link
Member

Hey Elliot. Thanks for working on this. Given that your aforementioned Ruff PR was merged, is this pull request still relevant?

@clockback
Copy link
Contributor Author

Hey Elliot. Thanks for working on this. Given that your aforementioned Ruff PR was merged, is this pull request still relevant?

It oughtn't make any difference if we merge now. If we merge after the next Ruff release, then I expect we'll remove the two inline warning suppressions before merging.

@clockback clockback force-pushed the enable-flake8-blind-except branch from 08e43a5 to 5d705df Compare July 31, 2025 04:35
Note that two inline suppressions are used. I expect, provided that my
[PR](astral-sh/ruff#19520) is merged in, that
these suppressions will become superfluous in a later version of Ruff.
@clockback clockback force-pushed the enable-flake8-blind-except branch from 5d705df to 10c0c29 Compare July 31, 2025 04:44
@clockback
Copy link
Contributor Author

I've removed the warning suppressions and bumped Ruff to v0.12.7. The tests are failing, and they seem to be failing on the main branch too.

@justinmayer
Copy link
Member

Odd. Tests pass on my local workstation, both on main and on this branch as well.

@justinmayer
Copy link
Member

@getpelican/reviewers: Could you possibly help diagnose why a bunch of tests are failing on main in CI but pass on my local workstation? Any investigative assistance you can offer would be very helpful! 😊

@boxydog
Copy link
Contributor

boxydog commented Oct 5, 2025

I have nothing useful yet, but I can say

  • I replicated your result of failing on github (link)
  • When I run invoke tests on my machine, some tests fail (but not so many). I'm still investigating why. I have to say, running invoke or invoke help doesn't list the tasks, which is unhelpful

I'll get back to this later.

@justinmayer
Copy link
Member

@boxydog: Thank you for your investigative efforts. Much appreciated!

You should be able to list the available Invoke tasks via: invoke --list (or invoke -l)

@boxydog
Copy link
Contributor

boxydog commented Oct 5, 2025

It looks like main doesn't pass either.

I'm betting some dependency has changed. The dependencies in pyproject.toml allow a lot of different combinations.

I'm experimenting with combinations of dependencies.

@boxydog
Copy link
Contributor

boxydog commented Oct 6, 2025

Pinning docutils to 0.20.1 allows all tests to pass on main (#3506), while docutils 0.22 fails.

That same pin allows this branch to pass tests (link).

@boxydog
Copy link
Contributor

boxydog commented Oct 6, 2025

Filed #3507, which says that docutils >= 0.22 fails.

@justinmayer justinmayer changed the title Enable Ruff rule blind-except. Enable Ruff rule blind-except Oct 17, 2025
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks to @clockback for the enhancement and to @boxydog for tracking down the source of the test failures 👍

@justinmayer justinmayer merged commit 91d55a4 into getpelican:main Oct 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants