Enable Ruff rule blind-except.

Note that two inline suppressions are used. I expect, provided that my
[PR](astral-sh/ruff#19520) is merged in, that
these suppressions will become superfluous in a later version of Ruff.

Author: clockback

pelican/__init__.py

@@ -37,7 +37,7 @@
 
 try:
     __version__ = importlib.metadata.version("pelican")
-except Exception:
+except importlib.metadata.PackageNotFoundError:
     __version__ = "unknown"
 
 DEFAULT_CONFIG_NAME = "pelicanconf.py"
@@ -78,11 +78,10 @@ def init_plugins(self):
             try:
                 plugin.register()
                 self.plugins.append(plugin)
-            except Exception as e:
-                logger.error(
-                    "Cannot register plugin `%s`\n%s",
+            except Exception:
+                logger.exception(
+                    "Cannot register plugin `%s`",
                     name,
-                    e,
                     stacklevel=2,
                 )
                 if self.settings.get("DEBUG", False):
@@ -257,8 +256,8 @@ def __call__(self, parser, namespace, values, option_string):
 
         try:
             instance, settings = get_instance(namespace)
-        except Exception as e:
-            logger.critical("%s: %s", e.__class__.__name__, e)
+        except Exception as e:  # noqa: BLE001 (blind-except)
+            logger.critical("%s", e.__class__.__name__, exc_info=True)
             console.print_exception()
             sys.exit(getattr(e, "exitcode", 1))
 
@@ -621,7 +620,8 @@ def listen(server, port, output, excqueue=None):
     except Exception as e:
         if excqueue is not None:
             excqueue.put(traceback.format_exception_only(type(e), e)[-1])
-        return
+        else:
+            logging.exception("Listening aborted unexpectedly.")
 
     except KeyboardInterrupt:
         httpd.socket.close()
@@ -679,8 +679,8 @@ def main(argv=None):
                 pelican.run()
     except KeyboardInterrupt:
         logger.warning("Keyboard interrupt received. Exiting.")
-    except Exception as e:
-        logger.critical("%s: %s", e.__class__.__name__, e)
+    except Exception as e:  # noqa: BLE001 (blind-except)
+        logger.critical("%s: %s", e.__class__.__name__, e, exc_info=True)
 
         if args.verbosity == logging.DEBUG:
             console.print_exception()

pelican/generators.py

@@ -681,11 +681,10 @@ def generate_context(self):
                         context_signal=signals.article_generator_context,
                         context_sender=self,
                     )
-                except Exception as e:
-                    logger.error(
-                        "Could not process %s\n%s",
+                except Exception:
+                    logger.exception(
+                        "Could not process %s",
                         f,
-                        e,
                         exc_info=self.settings.get("DEBUG", False),
                     )
                     self._add_failed_source_path(f)
@@ -896,11 +895,10 @@ def generate_context(self):
                         context_signal=signals.page_generator_context,
                         context_sender=self,
                     )
-                except Exception as e:
-                    logger.error(
-                        "Could not process %s\n%s",
+                except Exception:
+                    logger.exception(
+                        "Could not process %s",
                         f,
-                        e,
                         exc_info=self.settings.get("DEBUG", False),
                     )
                     self._add_failed_source_path(f)

pelican/tools/pelican_themes.py

@@ -241,7 +241,7 @@ def install(path, v=False, u=False):
                         f"or directory in `{theme_path}':\n{e!s}",
                         die=False,
                     )
-            except Exception as e:
+            except OSError as e:
                 err(f"Cannot copy `{path}' to `{theme_path}':\n{e!s}")
 
 
@@ -262,7 +262,7 @@ def symlink(path, v=False):
                 print(f"Linking `{path}' to `{theme_path}' ...")
             try:
                 os.symlink(path, theme_path)
-            except Exception as e:
+            except OSError as e:
                 err(f"Cannot link `{path}' to `{theme_path}':\n{e!s}")
 
 

pelican/utils.py

@@ -378,8 +378,8 @@ def clean_output_dir(path: str, retention: Iterable[str]) -> None:
     if not os.path.isdir(path):
         try:
             os.remove(path)
-        except Exception as e:
-            logger.error("Unable to delete file %s; %s", path, e)
+        except Exception:
+            logger.exception("Unable to delete file %s", path)
         return
 
     # remove existing content from output folder unless in retention list
@@ -393,14 +393,14 @@ def clean_output_dir(path: str, retention: Iterable[str]) -> None:
             try:
                 shutil.rmtree(file)
                 logger.debug("Deleted directory %s", file)
-            except Exception as e:
-                logger.error("Unable to delete directory %s; %s", file, e)
+            except Exception:
+                logger.exception("Unable to delete directory %s", file)
         elif os.path.isfile(file) or os.path.islink(file):
             try:
                 os.remove(file)
                 logger.debug("Deleted file/link %s", file)
-            except Exception as e:
-                logger.error("Unable to delete file %s; %s", file, e)
+            except Exception:
+                logger.exception("Unable to delete file %s", file)
         else:
             logger.error("Unable to delete %s, file type unknown", file)
 
@@ -764,7 +764,7 @@ def order_content(
             try:
                 content_list.sort(key=order_by)
             except Exception:
-                logger.error("Error sorting with function %s", order_by)
+                logger.exception("Error sorting with function %s", order_by)
         elif isinstance(order_by, str):
             if order_by.startswith("reversed-"):
                 order_reversed = True

pelican/writers.py

@@ -161,10 +161,7 @@ def write_feed(
         if path:
             complete_path = sanitised_join(self.output_path, path)
 
-            try:
-                os.makedirs(os.path.dirname(complete_path))
-            except Exception:
-                pass
+            os.makedirs(os.path.dirname(complete_path), exist_ok=True)
 
             with self._open_w(complete_path, "utf-8", override_output) as fp:
                 feed.write(fp, "utf-8")
@@ -215,10 +212,7 @@ def _write_file(template, localcontext, output_path, name, override):
             output = template.render(localcontext)
             path = sanitised_join(output_path, name)
 
-            try:
-                os.makedirs(os.path.dirname(path))
-            except Exception:
-                pass
+            os.makedirs(os.path.dirname(path), exist_ok=True)
 
             with self._open_w(path, "utf-8", override=override) as f:
                 f.write(output)

pyproject.toml

@@ -127,7 +127,7 @@ select = [
     "A",   # flake8-builtins
     "ARG", # flake8-unused-arguments
     "B",   # flake8-bugbear
-    # TODO: "BLE", # flake8-blind-except
+    "BLE", # flake8-blind-except
     # TODO: Do I want "COM", # flake8-commas
     "C4",  # flake8-comprehensions
     # TODO: "DJ",  # flake8-django