Skip to content

Set connectedToRemoteBrowser to false for non remote browser #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Set connectedToRemoteBrowser to false for non remote browser #2750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1de5ad
Set connectedToRemoteBrowser to false for non remote browser
Mar 13, 2025
1bfe40f
Bump version
Mar 14, 2025
d98ed8e
revert formatting change
Mar 17, 2025
83121cd
lock ubuntu version to prevent AppArmor issue
Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/taiko.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
node_version: ['20']
os: [ubuntu-latest, windows-latest]
os: [ubuntu-22.04, windows-latest]
steps:
- uses: actions/checkout@v4
- name: Use NodeJS ${{ matrix.node_version }}
Expand All @@ -29,7 +29,7 @@ jobs:
- name: install
run: npm install
- name: install browser dependencies
if: matrix.os == 'ubuntu-latest'
if: matrix.os == 'ubuntu-22.04'
run: |
sudo apt-get update
sudo apt-get install -y libnss3 \
Expand All @@ -55,7 +55,7 @@ jobs:
strategy:
matrix:
node_version: ['20']
os: [ubuntu-latest, windows-latest]
os: [ubuntu-22.04, windows-latest]

steps:
- uses: actions/checkout@v4
Expand All @@ -64,7 +64,7 @@ jobs:
with:
node-version: ${{ matrix.node_version }}
- name: install browser dependencies
if: matrix.os == 'ubuntu-latest'
if: matrix.os == 'ubuntu-22.04'
run: |
sudo apt-get update
sudo apt-get install -y \
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
functional-tests-headful:
needs: unit-tests
name: FT in linux-headful
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Use NodeJS 20
Expand Down Expand Up @@ -144,7 +144,7 @@ jobs:
docs-tests:
needs: unit-tests
name: Docs tests
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Use NodeJS 20
Expand Down
1 change: 1 addition & 0 deletions lib/taiko.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ module.exports.openBrowser = async (
defaultConfig.host = currentHost;
defaultConfig.port = currentPort;
defaultConfig.browserDebugUrl = browserDebugUrl;
defaultConfig.connectedToRemoteBrowser = false;
}
await connect_to_cri();
const description = defaultConfig.device
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "http://json.schemastore.org/package",
"name": "taiko",
"version": "1.4.3",
"version": "1.4.4",
"description": "Taiko is a Node.js library for automating Chromium based browsers",
"main": "bin/taiko.js",
"bin": {
Expand Down