Skip to content

Conversation

@rpradeepam
Copy link
Contributor

Fixes #2749
If we open a local browser after opening and closing a remote browser, the closeBrowser step hangs.
The connectedToRemoteBrowser property was not being reset after connecting to a remote browser.

Roshan Pradeepam added 2 commits March 14, 2025 11:05
Signed-off-by: Roshan Pradeepam <[email protected]>
@zabil
Copy link
Member

zabil commented Mar 17, 2025

@rpradeepam can you revert formatting changes so that the unit tests can run?

Signed-off-by: Roshan Pradeepam <[email protected]>
@rpradeepam
Copy link
Contributor Author

@rpradeepam can you revert formatting changes so that the unit tests can run?

Done

@rpradeepam
Copy link
Contributor Author

Tests are failing for me on local even without my changes. Not sure if it is because I am on a mac.

@rpradeepam
Copy link
Contributor Author

Locked the Ubuntu version used in Github Action to 22.04. Deploys till a few days back were using this version.

https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

@rpradeepam
Copy link
Contributor Author

@zabil all the checks have passed, but the reporting is showing as pending due the the change in check name. Do I need to do something here?

@zabil
Copy link
Member

zabil commented Mar 20, 2025

I think the pending tests are because of the ubuntu version pinning. Changed repository settings to reflect the status. Thanks for fixing the tests!

@gaugebot
Copy link

gaugebot bot commented Mar 20, 2025

@rpradeepam Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@zabil zabil merged commit 39cddbd into getgauge:master Mar 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

closeBrowser hangs in remote and local hybrid test case

2 participants