- 
                Notifications
    
You must be signed in to change notification settings  - Fork 450
 
Set connectedToRemoteBrowser to false for non remote browser #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Roshan Pradeepam <[email protected]>
Signed-off-by: Roshan Pradeepam <[email protected]>
| 
           @rpradeepam can you revert formatting changes so that the unit tests can run?  | 
    
Signed-off-by: Roshan Pradeepam <[email protected]>
          
 Done  | 
    
| 
           Tests are failing for me on local even without my changes. Not sure if it is because I am on a mac.  | 
    
Signed-off-by: Roshan Pradeepam <[email protected]>
| 
           Locked the Ubuntu version used in Github Action to 22.04. Deploys till a few days back were using this version. https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md  | 
    
| 
           @zabil all the checks have passed, but the reporting is showing as pending due the the change in check name. Do I need to do something here?  | 
    
| 
           I think the pending tests are because of the ubuntu version pinning. Changed repository settings to reflect the status. Thanks for fixing the tests!  | 
    
| 
           @rpradeepam Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.  | 
    
Fixes #2749
If we open a local browser after opening and closing a remote browser, the closeBrowser step hangs.
The
connectedToRemoteBrowserproperty was not being reset after connecting to a remote browser.