feat: format table numbers with a comma (#719) #720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #719.
This pull request introduces improvements to the formatting and display of numeric values in tables, as well as adjustments to table column widths for better layout consistency across the BRC Analytics Catalog UI. The most significant changes are the introduction and application of a
formatNumber
utility to ensure numeric values are consistently formatted, and a series of updates to table column minimum widths for improved readability and alignment.Number formatting improvements:
formatNumber
utility function inviewModelBuilders.ts
to format numbers with locale-aware separators, and applied this function to all relevant numeric cell renderers in genome and sequencing data tables. This ensures that values like counts and lengths are easier to read. [1] [2] [3] [4] [5] [6] [7] [8] [9]Table layout and column width adjustments:
gridTemplateColumns
property inbuildOrganismGenomesTable
to use wider minimum column widths, improving the appearance and usability of the genome tables.genomeEntityConfig
table configuration, including taxonomic levels, strain, serotype, isolate, and several numeric columns, to ensure better alignment and avoid text truncation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]