Skip to content

Conversation

frano-m
Copy link
Contributor

@frano-m frano-m commented Aug 19, 2025

Closes #719.

This pull request introduces improvements to the formatting and display of numeric values in tables, as well as adjustments to table column widths for better layout consistency across the BRC Analytics Catalog UI. The most significant changes are the introduction and application of a formatNumber utility to ensure numeric values are consistently formatted, and a series of updates to table column minimum widths for improved readability and alignment.

Number formatting improvements:

  • Added a new formatNumber utility function in viewModelBuilders.ts to format numbers with locale-aware separators, and applied this function to all relevant numeric cell renderers in genome and sequencing data tables. This ensures that values like counts and lengths are easier to read. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Table layout and column width adjustments:

  • Updated the gridTemplateColumns property in buildOrganismGenomesTable to use wider minimum column widths, improving the appearance and usability of the genome tables.
  • Increased the minimum widths for a variety of columns in the genomeEntityConfig table configuration, including taxonomic levels, strain, serotype, isolate, and several numeric columns, to ensure better alignment and avoid text truncation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]
image image image

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces number formatting with locale-aware separators for numeric table values and adjusts column widths across the BRC Analytics Catalog to improve readability and layout consistency.

  • Adds a formatNumber utility function that formats numbers with locale-specific separators (commas)
  • Applies number formatting to genome assembly counts, chromosome counts, length values, and scaffold metrics
  • Updates minimum column widths for taxonomic levels, strain/serotype/isolate fields, and numeric columns

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
genomeEntityConfig.ts Updates minimum column widths for taxonomic fields and numeric columns in genome table configuration
viewModelBuilders.ts Adds formatNumber utility and applies it to numeric cell renderers, updates grid template columns
columnDef.ts Applies number formatting to base count and read count columns in sequencing data tables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@frano-m frano-m force-pushed the fran/719-table-format branch from 91fa485 to 35438a1 Compare August 19, 2025 05:21
@NoopDog NoopDog force-pushed the fran/719-table-format branch from 35438a1 to 5386773 Compare August 19, 2025 15:14
@NoopDog NoopDog merged commit f62661f into main Aug 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Format table numbers with a comma
2 participants