Enable tooltips #98
Merged
Enable tooltips #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks great. 🚢 |
Users should never see an error page if a Git action fails. web_git should fail gracefully and redirect with a flash message if something doesn't work. This commit adds the following: - enables session in Sinatra to display flash messages. - refactors controller logic to rescue Git::GitExecuteError exceptions - displays flash messages on redirect
jelaniwoods
force-pushed
the
jw-enable-tooltips
branch
from
99d1dc2 to
4beb852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently Bootstrap tooltips do not work.
Solution
Additionally, I switch
letto the more widely supportedvarin the very rare case that someone tries to use an older browser.