Add notice and alerts #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rescue errors from git gem * display and clear flash messages
jelaniwoods
force-pushed
the
78-jw-add-notice-and-alerts
branch
from
7ce1147 to
96f6962
Compare
raghubetina
reviewed
Jun 7, 2021
raghubetina
reviewed
Jun 7, 2021
| @git ||= Git.open(working_dir) | ||
| end | ||
|
|
||
| def safe_git_action(method, **options) |
Contributor
There was a problem hiding this comment.
Love this method/refactor.
Contributor
|
Great idea. LGTM 🚢 |
jelaniwoods
added a commit
that referenced
this pull request
Jun 7, 2021
Users should never see an error page if a Git action fails. web_git should fail gracefully and redirect with a flash message if something doesn't work. This commit adds the following: - enables session in Sinatra to display flash messages. - refactors controller logic to rescue Git::GitExecuteError exceptions - displays flash messages on redirect
This was referenced Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #78
Resolves #88
Problem
Students often see a big ol' error page if Git or Gitpod settings aren't exactly right
Students should never see an error page like this.
web_gitshould fail gracefully and redirect with a flash message if something doesn't work.Solution
This PR does the following:
sessionin Sinatra to display flash messages.Git::GitExecuteErrorexceptions