Skip to content

Conversation

@cutoutsy
Copy link
Contributor

@cutoutsy cutoutsy commented Oct 24, 2025

Like trino_to_pa_value_type() function, improve trino_to_feast_value_type() function

  • Split decimal type into decimal32/decimal64 based on precision
  • Add support for real type mapping to ValueType.FLOAT
  • Add support for varchar(length) type
  • Add support for timestamp(p) type

@cutoutsy cutoutsy requested a review from a team as a code owner October 24, 2025 10:28
@cutoutsy cutoutsy changed the title fix: improve trino to feast type mapping with (real,varchar,timestamp… fix: Improve trino to feast type mapping with (real,varchar,timestamp,decimal) Oct 24, 2025
@cutoutsy cutoutsy force-pushed the fix/trino_to_feast_value_type branch from d6b2e65 to b62edeb Compare October 24, 2025 11:18
@ntkathole ntkathole force-pushed the fix/trino_to_feast_value_type branch from b23f1dc to 531a74c Compare October 26, 2025 03:42
Copy link
Collaborator

@shuchu shuchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franciscojavierarceo franciscojavierarceo merged commit f855ad2 into feast-dev:master Oct 29, 2025
22 of 23 checks passed
@cutoutsy cutoutsy deleted the fix/trino_to_feast_value_type branch October 30, 2025 08:21
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants