feat: Add batch commit mode for MySQL OnlineStore #5699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chimey Rock <[email protected]> docs: update document for MySQL Online Store to support batch write Signed-off-by: Chimey Rock <[email protected]>
|
@chimeyrock999 Thank you! Can we also please mention this support in our docs ? may be at https://github.com/feast-dev/feast/blob/master/docs/reference/online-stores/mysql.md |
Signed-off-by: Chimey Rock <[email protected]>
|
@ntkathole Thank you for the feedback! I’ve added documentation to cover this support of MySQL Online Store. |
ntkathole
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds optional batch insert and commit mode to the MySQLOnlineStore to improve materialization performance for TiDB and MySQL backends.
By default, Feast writes each row individually and commits per record, which causes large overhead on MySQL compatible Raft-based databases like TiDB.
This PR introduces a configurable batch mode to group inserts and commit per batch, improving write throughput.
Changes
executemany()/ multi-row SQL.Misc