Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/internal-test-utils/consoleMock.js
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ export function createLogAssertion(
let argIndex = 0;
// console.* could have been called with a non-string e.g. `console.error(new Error())`
// eslint-disable-next-line react-internal/safe-string-coercion
String(format).replace(/%s|%c/g, () => argIndex++);
String(format).replace(/%s|%c|%o/g, () => argIndex++);
if (argIndex !== args.length) {
if (format.includes('%c%s')) {
// We intentionally use mismatching formatting when printing badging because we don't know
Expand Down
21 changes: 21 additions & 0 deletions packages/react-server/src/ReactFlightServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -3354,6 +3354,27 @@ function renderModelDestructive(
task.debugOwner = element._owner;
task.debugStack = element._debugStack;
task.debugTask = element._debugTask;
if (
element._owner === undefined ||
element._debugStack === undefined ||
element._debugTask === undefined
) {
let key = '';
if (element.key !== null) {
key = ' key="' + element.key + '"';
}

console.error(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't do conditional throws but maybe this here is a valid exception since we'll throw later anyway in dev when accessing .stack?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might fix that to not throw though and then it would become unbalanced.

'Attempted to render <%s%s> without development properties. ' +
'This is not supported. It can happen if:' +
'\n- The element is created with a production version of React but rendered in development.' +
'\n- The element was cloned with a custom function instead of `React.cloneElement`.\n' +
'The props of this element may help locate this element: %o',
element.type,
key,
element.props,
);
}
// TODO: Pop this. Since we currently don't have a point where we can pop the stack
// this debug information will be used for errors inside sibling properties that
// are not elements. Leading to the wrong attribution on the server. We could fix
Expand Down
24 changes: 24 additions & 0 deletions packages/react-server/src/__tests__/ReactFlightServer-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ let ReactNoopFlightServer;
let Scheduler;
let advanceTimersByTime;
let assertLog;
let assertConsoleErrorDev;

describe('ReactFlight', () => {
beforeEach(() => {
Expand Down Expand Up @@ -64,6 +65,7 @@ describe('ReactFlight', () => {
Scheduler = require('scheduler');
const InternalTestUtils = require('internal-test-utils');
assertLog = InternalTestUtils.assertLog;
assertConsoleErrorDev = InternalTestUtils.assertConsoleErrorDev;
});

afterEach(() => {
Expand Down Expand Up @@ -175,4 +177,26 @@ describe('ReactFlight', () => {
stackTwo: '\n in OwnerStackDelayed (at **)' + '\n in App (at **)',
});
});

it('logs an error when prod elements are rendered', async () => {
const element = ReactServer.createElement('span', {
key: 'one',
children: 'Free!',
});
ReactNoopFlightServer.render(
// bad clone
{...element},
);

assertConsoleErrorDev([
[
'Attempted to render <span key="one"> without development properties. This is not supported. It can happen if:' +
'\n- The element is created with a production version of React but rendered in development.' +
'\n- The element was cloned with a custom function instead of `React.cloneElement`.\n' +
"The props of this element may help locate this element: { children: 'Free!', [key]: [Getter] }",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the prettiest to include the legacy key getter but it gets the job done.

{withoutStack: true},
],
"TypeError: Cannot read properties of undefined (reading 'stack')",
]);
});
});
Loading