-
Notifications
You must be signed in to change notification settings - Fork 49.3k
[Flight] Log error if prod elements are rendered #34189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+46
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,7 @@ let ReactNoopFlightServer; | |
let Scheduler; | ||
let advanceTimersByTime; | ||
let assertLog; | ||
let assertConsoleErrorDev; | ||
|
||
describe('ReactFlight', () => { | ||
beforeEach(() => { | ||
|
@@ -64,6 +65,7 @@ describe('ReactFlight', () => { | |
Scheduler = require('scheduler'); | ||
const InternalTestUtils = require('internal-test-utils'); | ||
assertLog = InternalTestUtils.assertLog; | ||
assertConsoleErrorDev = InternalTestUtils.assertConsoleErrorDev; | ||
}); | ||
|
||
afterEach(() => { | ||
|
@@ -175,4 +177,26 @@ describe('ReactFlight', () => { | |
stackTwo: '\n in OwnerStackDelayed (at **)' + '\n in App (at **)', | ||
}); | ||
}); | ||
|
||
it('logs an error when prod elements are rendered', async () => { | ||
const element = ReactServer.createElement('span', { | ||
key: 'one', | ||
children: 'Free!', | ||
}); | ||
ReactNoopFlightServer.render( | ||
// bad clone | ||
{...element}, | ||
); | ||
|
||
assertConsoleErrorDev([ | ||
[ | ||
'Attempted to render <span key="one"> without development properties. This is not supported. It can happen if:' + | ||
'\n- The element is created with a production version of React but rendered in development.' + | ||
'\n- The element was cloned with a custom function instead of `React.cloneElement`.\n' + | ||
"The props of this element may help locate this element: { children: 'Free!', [key]: [Getter] }", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not the prettiest to include the legacy key getter but it gets the job done. |
||
{withoutStack: true}, | ||
], | ||
"TypeError: Cannot read properties of undefined (reading 'stack')", | ||
]); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't do conditional throws but maybe this here is a valid exception since we'll throw later anyway in dev when accessing
.stack
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might fix that to not throw though and then it would become unbalanced.