[Flight] Log error if prod elements are rendered #34189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Aug 12, 2025
| 'Attempted to render <span key="one"> without development properties. This is not supported. It can happen if:' + | ||
| '\n- The element is created with a production version of React but rendered in development.' + | ||
| '\n- The element was cloned with a custom function instead of `React.cloneElement`.\n' + | ||
| "The props of this element may help locate this element: { children: 'Free!', [key]: [Getter] }", |
There was a problem hiding this comment.
Not the prettiest to include the legacy key getter but it gets the job done.
eps1lon
commented
Aug 12, 2025
| key = ' key="' + element.key + '"'; | ||
| } | ||
|
|
||
| console.error( |
There was a problem hiding this comment.
We usually don't do conditional throws but maybe this here is a valid exception since we'll throw later anyway in dev when accessing .stack?
There was a problem hiding this comment.
We might fix that to not throw though and then it would become unbalanced.
sebmarkbage
approved these changes
Aug 13, 2025
This was referenced Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously encountered these errors with MDX. The newest issue was a
lodash.cloneDeep(objWithReactElements).Example: