Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/browser/ui/ReactDOMIDOperations.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ var ReactMount = require('ReactMount');
var ReactPerf = require('ReactPerf');

var invariant = require('invariant');
var setInnerHTML = require('setInnerHTML');

/**
* Errors for properties that should not be updated with `updatePropertyById()`.
Expand Down Expand Up @@ -108,7 +107,7 @@ var ReactDOMIDOperations = {
*/
updateInnerHTMLByID: function(id, html) {
var node = ReactMount.getNode(id);
setInnerHTML(node, html);
DOMChildrenOperations.dangerouslyUpdateInnerHTML(node, html);
},

/**
Expand Down
4 changes: 2 additions & 2 deletions src/browser/ui/ReactMount.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

'use strict';

var Danger = require('Danger');
var DOMProperty = require('DOMProperty');
var ReactBrowserEventEmitter = require('ReactBrowserEventEmitter');
var ReactCurrentOwner = require('ReactCurrentOwner');
Expand All @@ -30,7 +31,6 @@ var containsNode = require('containsNode');
var getReactRootElementInContainer = require('getReactRootElementInContainer');
var instantiateReactComponent = require('instantiateReactComponent');
var invariant = require('invariant');
var setInnerHTML = require('setInnerHTML');
var shouldUpdateReactComponent = require('shouldUpdateReactComponent');
var warning = require('warning');

Expand Down Expand Up @@ -854,7 +854,7 @@ var ReactMount = {
'See React.renderToString() for server rendering.'
);

setInnerHTML(container, markup);
Danger.dangerouslyUpdateInnerHTML(container, markup);
},

/**
Expand Down
2 changes: 2 additions & 0 deletions src/browser/ui/dom/DOMChildrenOperations.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ var DOMChildrenOperations = {

dangerouslyReplaceNodeWithMarkup: Danger.dangerouslyReplaceNodeWithMarkup,

dangerouslyUpdateInnerHTML: Danger.dangerouslyUpdateInnerHTML,

updateTextContent: setTextContent,

/**
Expand Down
18 changes: 18 additions & 0 deletions src/browser/ui/dom/Danger.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,24 @@ var Danger = {

var newChild = createNodesFromMarkup(markup, emptyFunction)[0];
oldChild.parentNode.replaceChild(newChild, oldChild);
},

/**
* Replaces the content of a container with a string of html.
*
* @param {DOMElement} container Container to update innerHTML for.
* @param {string} html An HTML string.
* @internal
*/
dangerouslyUpdateInnerHTML: function(container, html) {
while (container.lastChild) {
container.removeChild(container.lastChild);
}

var newChildren = createNodesFromMarkup(html, emptyFunction);
for (var i = 0; i < newChildren.length; i++) {
container.appendChild(newChildren[i]);
}
}

};
Expand Down
87 changes: 0 additions & 87 deletions src/browser/ui/dom/setInnerHTML.js

This file was deleted.

5 changes: 3 additions & 2 deletions src/browser/ui/dom/setTextContent.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@

'use strict';

var Danger = require('Danger');
var ExecutionEnvironment = require('ExecutionEnvironment');
var escapeTextContentForBrowser = require('escapeTextContentForBrowser');
var setInnerHTML = require('setInnerHTML');

/**
* Set the textContent property of a node, ensuring that whitespace is preserved
Expand All @@ -32,7 +32,8 @@ var setTextContent = function(node, text) {
if (ExecutionEnvironment.canUseDOM) {
if (!('textContent' in document.documentElement)) {
setTextContent = function(node, text) {
setInnerHTML(node, escapeTextContentForBrowser(text));
var html = escapeTextContentForBrowser(text);
Danger.dangerouslyUpdateInnerHTML(node, html);
};
}
}
Expand Down