Replace setInnerHTML with Danger.dangerouslyUpdateInnerHTML, uses createNodesFromMarkup #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2014
syranide
changed the title
This was referenced Oct 14, 2014
This was referenced Jan 4, 2015
…ateNodesFromMarkup
Collaborator
|
We're moving away from HTML except for server rendering so this is moot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2273, fixes: #2247 (replaces #2249)
setInnerHTMLandcreateNodesFromMarkupare two separate solutions to solve (largely) the same problem.createNodesFromMarkupsolves more edge-cases. This PR replaces the guts ofsetInnerHTMLwithcreateNodesFromMarkupinstead and movessetInnerHTMLintoDanger.dangerouslyUpdateInnerHTMLwhere it belongs.If we want to optimize performance then
createNodesFormMarkupseems to have few things that could be optimized. We could also useinnerHTMLdirectly for browsers that don't fail the whitespace test or doesn't have issues withinnerHTMLfor certain tags (but this should probably be incorporated intocreateNodesFromMarkupfor best result instead).npm testA test now fails because of yet another case of JSDOM being too strict/buggy, issue: #3146.