Skip to content

add settings to android webview to allow enabling file scheme and thi… #9949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thurber wants to merge 1 commit into from
Closed

add settings to android webview to allow enabling file scheme and thi… #9949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Libraries/Components/WebView/WebView.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,18 @@ class WebView extends React.Component {
*/
javaScriptEnabled: PropTypes.bool,

/**
* Used on Android only, controls whether or not to allow cookies for file:/// urls
* @platform android
*/
acceptFileSchemeCookies: PropTypes.bool,

/**
* Used on Android only, controls whether or not to allow third party cookies
* @platform android
*/
acceptThirdPartyCookies: PropTypes.bool,

/**
* Used on Android only, controls whether DOM Storage is enabled or not
* @platform android
Expand Down Expand Up @@ -217,6 +229,8 @@ class WebView extends React.Component {
injectedJavaScript={this.props.injectedJavaScript}
userAgent={this.props.userAgent}
javaScriptEnabled={this.props.javaScriptEnabled}
acceptFileSchemeCookies={this.props.acceptFileSchemeCookies}
acceptThirdPartyCookies={this.props.acceptThirdPartyCookies}
domStorageEnabled={this.props.domStorageEnabled}
contentInset={this.props.contentInset}
automaticallyAdjustContentInsets={this.props.automaticallyAdjustContentInsets}
Expand Down
12 changes: 12 additions & 0 deletions Libraries/Components/WebView/WebView.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,18 @@ class WebView extends React.Component {
*/
javaScriptEnabled: PropTypes.bool,

/**
* Used on Android only, controls whether or not to allow cookies for file:/// urls
* @platform android
*/
acceptFileSchemeCookies: PropTypes.bool,

/**
* Used on Android only, controls whether or not to allow third party cookies
* @platform android
*/
acceptThirdPartyCookies: PropTypes.bool,

/**
* Boolean value to control whether DOM Storage is enabled. Used only in
* Android.
Expand Down
11 changes: 11 additions & 0 deletions ReactAndroid/src/main/java/com/facebook/react/views/webview/ReactWebViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import android.os.Build;
import android.text.TextUtils;
import android.view.ViewGroup.LayoutParams;
import android.webkit.CookieManager;
import android.webkit.GeolocationPermissions;
import android.webkit.WebChromeClient;
import android.webkit.WebView;
Expand Down Expand Up @@ -281,6 +282,16 @@ public void setJavaScriptEnabled(WebView view, boolean enabled) {
view.getSettings().setJavaScriptEnabled(enabled);
}

@ReactProp(name = "acceptFileSchemeCookies")
public void setAcceptFileSchemeCookies(WebView view, boolean enabled) {
CookieManager.setAcceptFileSchemeCookies(enabled);
}

@ReactProp(name = "acceptThirdPartyCookies")
public void setAcceptThirdPartyCookies(WebView view, boolean enabled) {
CookieManager.getInstance().setAcceptThirdPartyCookies(view, enabled);
}

@ReactProp(name = "scalesPageToFit")
public void setScalesPageToFit(WebView view, boolean enabled) {
view.getSettings().setUseWideViewPort(!enabled);
Expand Down