Skip to content

Conversation

@thurber
Copy link

@thurber thurber commented Sep 16, 2016

Add two props to android WebView:

  • acceptFileSchemeCookies: controls whether or not android WebViews that load file scheme urls are allowed to used cookies
  • acceptThirdPartyCookies: controls whether or not android WebViews allow third party cookies

@ghost
Copy link

ghost commented Sep 16, 2016

By analyzing the blame information on this pull request, we identified @spicyj and @caabernathy to be potential reviewers.

@ghost
Copy link

ghost commented Sep 16, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2016
@facebook-github-bot
Copy link
Contributor

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @jacobp100 as a potential reviewer. Could you take a look please or cc someone with more context?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2016
@hramos
Copy link
Contributor

hramos commented Nov 11, 2016

What issue is this solving? Can you add tests?

@thurber
Copy link
Author

thurber commented Nov 16, 2016

I had needed this to be able to view pdfs via an implementation of Mozilla's pdfjs embedded as a file url, when the pdfs required a previously obtained session cookie to access. I've since implemented a workaround, so happy to close out this PR if no one else needs it.

@jacobp100
Copy link
Contributor

jacobp100 commented Nov 16, 2016

There's another PR (#10946) that lets you add behaviour to the existing web view. I think this is quite specific, so I think we should wait and see what happens with said PR.

@lacker
Copy link
Contributor

lacker commented Feb 8, 2017

I think we have too many possible configurable behavior things to add every prop to WebView, so if the approach in 10946 works that is ideal. Let's close this pull request but we can reopen if more general approaches fail.

@lacker lacker closed this Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants