Skip to content

Conversation

@hramos
Copy link
Contributor

@hramos hramos commented Aug 5, 2016

#9149 resolved an issue where Edit on GitHub links lead to a release branch, which results in pull requests being opened against a release branch instead of master. Many issues "resolved" in this manner have already been addressed in master.

This PR is intentionally against 0.31-stable as it is cherry-picking changes already landed to master.

See prior discussion in #9222. This new PR uses the single squashed commit, and does so against 0.31-stable, which is now the latest release.

Summary:
We've been getting a lot of documentation PRs opened against `0.29-stable`, `0.30-stable`, and so on, instead of `master`. This is because our doc site is also based on RN release cuts, so clicking on the "Edit on GitHub" links on a document will take you to the markdown source for that release branch instead of the latest doc on `master`.

See #9095 for an example of such a PR.

In this PR we edit the link to say View on GitHub. Though it may not prevent PRs from being opened against a release branch, removing the "Edit" CTA may help in this regard.
Closes #9149

Differential Revision: D3664368

Pulled By: vjeux

fbshipit-source-id: 395c0813f736bfbe1be4b4fb1182f9060169365d
@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @caabernathy and @JoelMarcey to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 5, 2016
@JoelMarcey
Copy link

Awesome thanks. Merging.

@JoelMarcey JoelMarcey merged commit e3c81fa into facebook:0.31-stable Aug 5, 2016
@bestander
Copy link
Contributor

You don't have to bump them.
Just add tag "latest" to the last commit of 0.31-stable branch and make CircleCI build it.
This does not have to cause an npm release.

@JoelMarcey
Copy link

@bestander I thought I knew how to bump something, but maybe I don't. This is what I did:

% git fetch
% git checkout -b 0.31-stable origin/0.31-stable
% git tag -d latest
% git tag latest
% git push origin :latest
% git push --tags

But I don't see the tag updated here nor CircleCI running.

What did I miss?

@bestander
Copy link
Contributor

@JoelMarcey, I don't see this commit in 0.31-stable branch https://github.com/facebook/react-native/commits/0.31-stable.
You should push 0.31-stable explicitly.
git push origin 0.31-stable --tags

@JoelMarcey
Copy link

@bestander Ok. We talked offline about this. It was because we didn't run the instructions above within 1 hour of this cherry-picked commit landing in the stable branch. So you had to trigger the CircleCI build manually in that case.

In the future, I can just push a dummy commit to the stable branch and then run the tag instructions within an hour to get the CircleCI build going.

@JoelMarcey
Copy link

@hramos Your Edit on GitHub update should be available in the next hour or so.

@hramos hramos deleted the 0.31-stable branch August 22, 2016 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants