-
Notifications
You must be signed in to change notification settings - Fork 25k
Cherry-pick #9149 into 0.30-stable branch #9222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…he Components autodocs.
|
@JoelMarcey you're the cherry-picking expert here, did I do it right? :) |
|
By analyzing the blame information on this pull request, we identified @caabernathy and @JoelMarcey to be potential reviewers. |
|
@hramos I think so. I see 8 commits here. We all of these commits part of one final squashed commit when landed into |
|
My process here was:
Seems like for step 2 I should have cherry-picked just the one squashed commit to master instead? That being 01cb1e4 |
|
@hramos Yeah. I think the one, squashed commit would be better to cherry-pick moving forward. However, GitHub loves us and gives us a So we are ok for this one, as long as we choose that. |
|
cc @grabbou |
|
Since 0.31 stable is now out, I'll go ahead and open a new PR against it with a proper single squashed commit. |

#9149 resolved an issue where Edit on GitHub links lead to a release branch, which results in pull requests being opened against a release branch instead of master. Many issues "resolved" in this manner have already been addressed in master.
This PR is intentionally against
0.30-stableas it is cherry-picking changes already landed to master.