Skip to content

Conversation

@sergioramos
Copy link

With the recent commander adition to the local-cli (ref), some parameters were misconfigured.

This change makes sure that parameters like reset-cache are accepting a boolean argument. Without this, when running the bundle command, it wouldn't recognize the
--reset-cache true parameter and just show the command help.

with @fampinheiro

Without this, when running the bundle command, it wouldn't recognize the
`--reset-cache true` parameter and just show the command help.

with @fampinheiro
@ghost
Copy link

ghost commented Aug 4, 2016

By analyzing the blame information on this pull request, we identified @grabbou and @mroswald to be potential reviewers.

@ghost
Copy link

ghost commented Aug 4, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@sergioramos
Copy link
Author

Just noticed that #9163 also fixes this bug, but --verbose is still broken with that fix

@mroswald
Copy link
Contributor

mroswald commented Aug 4, 2016

LGTM, @grabbou: ship-it ?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@ghost
Copy link

ghost commented Aug 4, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2016
@grabbou
Copy link
Contributor

grabbou commented Aug 5, 2016

Hey, thanks for the PR. I think --verbose is still better than --verbose true, esp. given that we already shipped --reset-cache w/o boolean to master and RCs. Do you think it's possible to fix verbose issues so that it works w/o true?

@ghost
Copy link

ghost commented Sep 3, 2016

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @grabbou as a potential reviewer. Could you take a look please or cc someone with more context?

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2016
@hramos hramos closed this Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants