--reset-cache no longer accept a boolean parameter. #9163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @philikon and @AndrewJack to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
danielbraun
referenced
this pull request
Aug 2, 2016
Summary: This is an initial step of rewriting the CLI interface to use `rnpm` one (commander, plugins etc.). It's scope is to move all existing commands to use rnpm CLI interface, so that we get plugins, flags and our existing ecosystem working out of the box. <s>This is still WIP and some of the commands are left commented out.</s> For the `config` of `rnpm` (functions get info about project and dependency), <s>I am thinking we can merge them with</s> we decided to merge it with [`default.config.js`](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e70adb69675786/local-cli/default.config.js#L33), so they are available on the `new Config()` [instance](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e70adb69675786/local-cli/cliEntry.js#L59) (which means we don't have to change anything and current plugins, like runIOS and runAndroid can just start using it [w/o depending on any extra argument](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e Closes #7899 Differential Revision: D3613193 Pulled By: bestander fbshipit-source-id: 09a072f3b21e5239dfcd8da88a205bd28dc5d037
ghost
added
the
CLA Signed
Contributor
|
cc @Kureev |
ghost
added
the
CLA Signed
Contributor
|
@danielbraun updated the pull request. |
ghost
added
the
CLA Signed
Contributor
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. |
ghost
added
the
CLA Signed
ghost
added
the
CLA Signed
bartolkaruza
pushed a commit
to immidi/react-native
that referenced
this pull request
Aug 3, 2016
Summary: The gradle :app:bundleReleaseJsAndAssets task is currently broken on master. Gradle attaches a boolean parameter to --reset-cache, while it no longer accepts it. Related: * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 * facebook#9134 * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 Closes facebook#9163 Differential Revision: D3659300 fbshipit-source-id: 798f211407ee279e9adc98948e94b212da84555a
grabbou
pushed a commit
that referenced
this pull request
Aug 5, 2016
Summary: The gradle :app:bundleReleaseJsAndAssets task is currently broken on master. Gradle attaches a boolean parameter to --reset-cache, while it no longer accepts it. Related: * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 * #9134 * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 Closes #9163 Differential Revision: D3659300 fbshipit-source-id: 798f211407ee279e9adc98948e94b212da84555a
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: The gradle :app:bundleReleaseJsAndAssets task is currently broken on master. Gradle attaches a boolean parameter to --reset-cache, while it no longer accepts it. Related: * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 * facebook#9134 * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 Closes facebook#9163 Differential Revision: D3659300 fbshipit-source-id: 798f211407ee279e9adc98948e94b212da84555a
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: The gradle :app:bundleReleaseJsAndAssets task is currently broken on master. Gradle attaches a boolean parameter to --reset-cache, while it no longer accepts it. Related: * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 * facebook#9134 * https://github.com/facebook/react-native/blob/master/local-cli/bundle/bundleCommandLineArgs.js#L52 Closes facebook#9163 Differential Revision: D3659300 fbshipit-source-id: 798f211407ee279e9adc98948e94b212da84555a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradle :app:bundleReleaseJsAndAssets task is currently broken on master.
Gradle attaches a boolean parameter to --reset-cache, while it no longer accepts it.
Related: