Android WebSocket: include cookies with request

[bradleyboy]

This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: #5630

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @satya164 and @aprock to be potential reviewers.

[vmakhaev]

LGTM. Any chances to merge this soon?

[satya164]

@bradleyboy Can you provide a test plan?

[bradleyboy]

@satya164 I've been working on a IRC client that authenticates the user via a WebView, then opens a WebSocket for the rest of the communication thereafter. This worked fine on iOS (once #5630 landed), but did not work on Android as the cookies aren't passed currently. With this patch applied, I've confirmed that the behavior is consistent between both platforms.

[satya164]

@bradleyboy Would be awesome to have an example in UIExplorer that we could test.

[facebook-github-bot]

@bradleyboy updated the pull request.

[facebook-github-bot]

@bradleyboy updated the pull request.

[facebook-github-bot]

@bradleyboy updated the pull request.

[ghost]

@satya164 would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

[vmakhaev]

Would be happy to see it merged finally. This blocks using cookies for auth.

[dentrado]

Any news regarding this? I saw that a similar PR is open for iOS, maybe some examples and/or tests can be shared: #7167

[mkonicek]

Let's merge this since we do the same on iOS:

react-native/Libraries/WebSocket/RCTSRWebSocket.m

Line 293 in 2f78852

- (instancetype)initWithURL:(NSURL *)URL protocols:(NSArray<NSString *> *)protocols;

It would be ideal to have an example in the UI Explorer but the test plan @bradleyboy provided looks good.

@facebook-github-bot shipit

[mkonicek]

@bradleyboy Let's see if the patch still applies on top of master.

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

[ghost]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[ghost]

@bradleyboy updated the pull request - view changes - changes since last import

[bradleyboy]

@mkonicek Just rebased and force pushed this, so it should be clean now. CI looks 👍

[mkonicek]

Thanks for the patience @bradleyboy :)