Skip to content

iOS websocket: include cookies with request #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jellevandenhooff wants to merge 1 commit into from
Closed

iOS websocket: include cookies with request #5630

jellevandenhooff wants to merge 1 commit into from

Conversation

@jellevandenhooff
Copy link

@jellevandenhooff jellevandenhooff commented Jan 29, 2016

This PR modifies the Websocket implementation on iOS to pass cookies to the server. Sending cookies is useful for clients that wish to access protected Websocket endpoints without creating a new authentication protocol.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 29, 2016

By analyzing the blame information on this pull request, we identified @nicklockwood, @hharnisc and @joenoon to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 29, 2016
@martinbigio
Copy link
Contributor

martinbigio commented Jan 29, 2016

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 29, 2016

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/445496482317600/int_phab to review.

@jellevandenhooff
Copy link
Author

jellevandenhooff commented Feb 1, 2016

Hi @martinbigio, please let me know if you need anything else on this PR. Thanks!

@nicklockwood
Copy link
Contributor

nicklockwood commented Feb 1, 2016

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 1, 2016

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/445496482317600/int_phab to review.

@ghost ghost closed this in debcac5 Feb 1, 2016
bradleyboy added a commit to bradleyboy/react-native that referenced this pull request Feb 21, 2016
@bradleyboy
Android WebSocket: include cookies with request
a7de336 
This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: facebook#5630
@bradleyboy bradleyboy mentioned this pull request Feb 22, 2016
Closed
@rodrigopivi
Copy link

rodrigopivi commented Apr 4, 2016

This is not working for me on #master.

I expect the first handshake request to send the httpOnly cookies that were previously created using fetch, but they are not send. Is this still working for you on master @jellevandenhooff ?

@jellevandenhooff
Copy link
Author

jellevandenhooff commented May 19, 2016 •
edited
Loading

Hi @rodrigopivi, I think you're right that this no longer works on master. While looking at #7167, I found that 205b5d4 broke this commit by switching from initWithURL to initWithURLRequest. See my comment in #7167.

@mkonicek mkonicek mentioned this pull request Sep 9, 2016
Closed
ghost pushed a commit that referenced this pull request Sep 19, 2016
@bradleyboy
Android WebSocket: include cookies with request
04392f2 
Summary:
This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: #5630
Closes #6067

Differential Revision: D3841122

Pulled By: mkonicek

fbshipit-source-id: 6607424feeb31c9da4e370ebe4b33dbbedc0a446
ghost pushed a commit that referenced this pull request Sep 22, 2016
@bradleyboy
Reverted commit D3841122
61eb3e8 
Summary:
This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: #5630
Closes #6067

Differential Revision: D3841122

Pulled By: wutalman

fbshipit-source-id: 6dae03bdf1c4599f12c0b191fcc56a61952fb59e
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
@bradleyboy
Android WebSocket: include cookies with request
259d728 
This commit brings Android in line with iOS WebSockets by sending along cookies from the shared CookieManager. See: facebook/react-native#5630
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jellevandenhooff @facebook-github-bot @martinbigio @nicklockwood @rodrigopivi