Adding shouldForwardToReactInstance check in ReactDelegate for Bridgeless
#52112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Migrate com.facebook.react.ReactDelegate to Kotlin. ## Changelog: [ANDROID][BREAKING] - Migrate com.facebook.react.ReactDelegate to Kotlin. Some users implementing this class in Kotlin could have breakages. Pull Request resolved: facebook#52024 Test Plan: ```bash yarn test-android yarn android ``` Differential Revision: D76740335 Pulled By: cortinico
…geless Summary: Adding `shouldForwardToReactInstance` check in Bridgeless since it was missed in facebook#43351 **Changelog:** [ANDROID][FIXED] - Adding `shouldForwardToReactInstance` check in ReactDelegate for Bridgeless Differential Revision: D76908041
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76908041 |
Contributor
|
This pull request has been merged in 0f7bf66. |
Collaborator
|
This pull request was successfully merged by @arushikesarwani94 in 0f7bf66 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding
shouldForwardToReactInstancecheck in Bridgeless since it was missed in #43351Changelog:
[ANDROID][FIXED] - Adding
shouldForwardToReactInstancecheck in ReactDelegate for BridgelessDifferential Revision: D76908041