Skip to content

Conversation

@mateoguzmana
Copy link
Collaborator

Summary:

Migrate com.facebook.react.ReactDelegate to Kotlin.

Changelog:

[ANDROID][BREAKING] - Migrate com.facebook.react.ReactDelegate to Kotlin. Some users implementing this class in Kotlin could have breakages.

Test Plan:

yarn test-android
yarn android

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2025
@mateoguzmana mateoguzmana force-pushed the refactor/migrate-react-delegate-2 branch from 2e6ddb8 to ad5418a Compare June 14, 2025 11:55
@mateoguzmana mateoguzmana marked this pull request as ready for review June 15, 2025 06:08
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 15, 2025
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

arushikesarwani94 pushed a commit to arushikesarwani94/react-native that referenced this pull request Jun 18, 2025
Summary:
Migrate com.facebook.react.ReactDelegate to Kotlin.

## Changelog:

[ANDROID][BREAKING] - Migrate com.facebook.react.ReactDelegate to Kotlin. Some users implementing this class in Kotlin could have breakages.

Pull Request resolved: facebook#52024

Test Plan:
```bash
yarn test-android
yarn android
```

Differential Revision: D76740335

Pulled By: cortinico
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 19, 2025
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 50ea5b4.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mateoguzmana in 50ea5b4

When will my fix make it into a release? | How to file a pick request?

@cortinico
Copy link
Contributor

We had to revert this because it was causing a failure in one of our apps sadly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Reverted Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants