convert circleci workflows to github actions for android build and test #43644
Conversation
facebook-github-bot
added
the
CLA Signed
|
facebook-github-bot
added
the
Shared with Meta
Base commit: 2205880 |
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Great stuff 👍 I've left a couple of comments but then we can import this one
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| - name: Cache android build artifacts | ||
| uses: actions/[email protected] | ||
| with: | ||
| key: android-build-cache-${{ github.run_number}} |
There was a problem hiding this comment.
Shouldn't we specify also a restore key here?
There was a problem hiding this comment.
Unless you need a different restore key, it is not needed.
|
|
||
| echo ${{ steps.hermes-version.outputs.version }} | ||
| build_andriod: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
| runs-on: ubuntu-latest | |
| runs-on: 8-core-ubuntu |
Can we make this and other compilation heavy jobs on 8-core-ubuntu? This should be similar to the same machine we had on CircleCI
There was a problem hiding this comment.
You could, however these larger runners would need to be configured in your org with the label 8-core-ubuntu in order to run. There are no runners with this label available by default.
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 036ffbc. |
4 participants
Summary:
This pull request converts the CircleCI workflows to GitHub actions workflows. This change only inlcudes the android build and test jobs.
Changelog:
Test Plan:
Here is the latest workflow run in my fork.
https://fburl.com/workplace/f6mz6tmw